Opened 10 years ago

Closed 9 years ago

#1219 closed defect (fixed)

Error loop: "You need to toggle Tor or restart for your setting to take effect"...grrr

Reported by: burp Owned by:
Priority: High Milestone:
Component: Applications/Torbutton Version: 1.2.3
Severity: Keywords:
Cc: burp, mikeperry, phobos Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

OS: Ubuntu 9.1

Torbutton: v.1.2.3

Firefox: v.3.5.7 (Ubuntu canonical - 1.0)

Installed add-ons other than Torbutton:
a) Refcontrol v.0.8.13 (set to <forge>)
b) Ubuntu Firefox Modifications v.0.8

Issue:
After right-clicking on Torbutton > Preferences > OK > "You need to toggle Tor or restart for your setting to take effect" > OK;
the started message keeps popping up. If I only open and close Torbutton Prefences the messages window loads twice, requiring two
clicks of "OK" then stops loading. But, if I chagne settings in Prefeces the message window keeps re-loading after clicking OK,
not just twice but dozens of time. Attemping to toggle Torbutton does not help, it is locked becuase the message window keeps loading.
I had to "xkill" Firefox and restart to end the message loading over and over again.

P.S. A "preview task" button would be great so one can review the task message before sending...

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

torbutton-1.2.5pre3.xpi (422.2 KB) - added by mikeperry 9 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 10 years ago by burp

A little more info:

a) I just disabled the add-on "Ubuntu Firefox Modifications v.0.8" and the same Torbutton message loop exists.

b) The non-stop message window loop happens when the "Test Settings" feature in Torbutton fails. Ie. when polipo isn't running and I try the "Test Settings" button after test failure the non-stop loop happens.

c) <edit> If I open and close Preferences in Torbutton the message loads twice requiring me to click OK twice. And if I edit a setting, ex. "Close all Tor windows and tabs on toggle (optional)" the message loads twice requiring two clicks of OK.

Let me know if anymore info would be helpful.

comment:2 Changed 10 years ago by burp

Sorry for the format error on my last message. I forgot I have to manually hit the enter key for a new line to prevent
the long sentace. This is exactly why this flyspray *needs* a preview option, or at least an "edit" option for each
message...

comment:3 Changed 10 years ago by burp

hmmm...

This is just odd. Just now I toggled Torbutton on and the same message window loaded, I clicked OK button to close. Then
the Torbutton GUI loaded and the message window also loaded. I click OK *once again* (sigh) and the window kept re-loading.

I had to kill Firefox (once again) with xkill. Very frustrating!

comment:4 Changed 10 years ago by burp

Mike,

Will you not respond? Can I please get some type of confirmation on this issue? It's been days since I reported this
bug which is very annoying...

Please respond so I know what is going on! Thanks

comment:5 Changed 10 years ago by Ijan

I can confirm this problem with OS and browser versions as above and Torbutton 1.2.4.

comment:6 Changed 9 years ago by mikeperry

Phobos also ran into this when changing the user agent torbutton preference. Which torbutton perference are you guys
actually changing?

comment:7 Changed 9 years ago by phobos

I cranked up the logging levels in torbutton and recreated this error:

[02-27 21:01:53] Torbutton INFO: Passing on about:blank
[02-27 21:01:53] Torbutton DBUG: New tab
[02-27 21:01:53] Torbutton INFO: Tagging new window: false
[02-27 21:01:53] Torbutton DBUG: Added history listener
[02-27 21:01:53] Torbutton INFO: Early mapper check.
[02-27 21:01:53] Torbutton INFO: Cache failed for: about:blank
[02-27 21:01:53] Torbutton DBUG: Got browser about:blank for: about:blank, under: about:blank
[02-27 21:01:53] Torbutton DBUG: Tags updated.
[02-27 21:01:53] Torbutton INFO: Early mapper check.
[02-27 21:01:53] Torbutton DBUG: Got browser about:blank for: about:blank, under: about:blank
[02-27 21:01:53] Torbutton DBUG: Tags updated.
[02-27 21:01:55] Torbutton DBUG: Skipping saving tor tab: about:blank
[02-27 21:01:57] Torbutton DBUG: Skipping saving tor tab: about:blank
[02-27 21:01:57] Torbutton DBUG: Torbutton normal exit
[02-27 21:01:57] Torbutton INFO: Crash recover check
[02-27 21:01:57] Torbutton INFO: End crash recover check
[02-27 21:01:57] Torbutton INFO: Component Load 5: New CookieJarSelector @torproject.org/cookie-jar-selector;1
[02-27 21:01:57] Torbutton DBUG: Cookies saved
[02-27 21:01:57] Torbutton INFO: Original window closed. Searching for another
[02-27 21:02:04] Torbutton INFO: Component Load 1: New ContentPolicy (@torproject.org/cssblocker;1)
[02-27 21:02:04] Torbutton INFO: Component Load 2: Content window mapper online: @torproject.org/content-window-mapper;1
[02-27 21:02:04] Torbutton INFO: Skipping no insec: resource://gre/res/hiddenWindow.html
[02-27 21:02:04] Torbutton INFO: Component Load 3: New HistoryWrapper @mozilla.org/browser/nav-history-service;1
[02-27 21:02:04] Torbutton INFO: New window
[02-27 21:02:04] Torbutton INFO: called init()
[02-27 21:02:04] Torbutton DBUG: called init_prefs()
[02-27 21:02:04] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:04] Torbutton DBUG: using recommended settings
[02-27 21:02:04] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:04] Torbutton DBUG: setting panel style: text
[02-27 21:02:04] Torbutton DBUG: torbutton_init_jshooks()
[02-27 21:02:04] Torbutton DBUG: setting panel visibility
[02-27 21:02:04] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:04] Torbutton DBUG: called update_status: true,false
[02-27 21:02:04] Torbutton INFO: get_toolbutton(): did not find torbutton-button
[02-27 21:02:04] Torbutton INFO: init completed
[02-27 21:02:04] Torbutton INFO: Torbutton main window startup
[02-27 21:02:04] Torbutton INFO: Observer register
[02-27 21:02:04] Torbutton INFO: Observer register
[02-27 21:02:04] Torbutton INFO: Observer register
[02-27 21:02:04] Torbutton INFO: Observer register
[02-27 21:02:04] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:04] Torbutton INFO: Component Load 6: New LivemarkWrapper @mozilla.org/browser/livemark-service;2
[02-27 21:02:04] Torbutton INFO: Disabled livemarks
[02-27 21:02:04] Torbutton INFO: Setting timezone at true for mode true
[02-27 21:02:04] Torbutton DBUG: Setting timezone to UTC
[02-27 21:02:04] Torbutton INFO: Crash recover check
[02-27 21:02:04] Torbutton INFO: End crash recover check
[02-27 21:02:04] Torbutton INFO: Tagging new window: false
[02-27 21:02:04] Torbutton DBUG: Added history listener
[02-27 21:02:04] Torbutton INFO: called init()
[02-27 21:02:04] Torbutton DBUG: called init_prefs()
[02-27 21:02:04] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:04] Torbutton DBUG: called update_status: true,false
[02-27 21:02:04] Torbutton INFO: get_toolbutton(): did not find torbutton-button
[02-27 21:02:04] Torbutton INFO: init completed
[02-27 21:02:05] Torbutton INFO: Component Load: New SessionStoreService @mozilla.org/browser/sessionstore;1
[02-27 21:02:05] Torbutton INFO: Got doRestore
[02-27 21:02:05] Torbutton INFO: Setting initial state to: 1
[02-27 21:02:05] Torbutton INFO: Conditional set
[02-27 21:02:05] Torbutton NOTE: Restoring tor state
[02-27 21:02:05] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:05] Torbutton DBUG: Window: (723,1280) ?= (750,1280)
[02-27 21:02:05] Torbutton DBUG: Window is minimized/maximized
[02-27 21:02:10] Torbutton INFO: Blocked livemarks start from component
[02-27 21:02:10] Torbutton DBUG: opened preferences window
[02-27 21:02:10] Torbutton DBUG: called prefs_init()
[02-27 21:02:10] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:11] Torbutton DBUG: Got cookie pref change
[02-27 21:02:11] Torbutton DBUG: called prefs_set_field_attributes()
[02-27 21:02:11] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:11] Torbutton DBUG: using recommended settings
[02-27 21:02:11] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:13] Torbutton DBUG: called prefs_set_field_attributes()
[02-27 21:02:13] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:13] Torbutton DBUG: using recommended settings
[02-27 21:02:13] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:14] Torbutton DBUG: called prefs_set_field_attributes()
[02-27 21:02:14] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:14] Torbutton DBUG: using recommended settings
[02-27 21:02:14] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:16] Torbutton DBUG: called prefs_save()
[02-27 21:02:16] Torbutton DBUG: setting panel visibility
[02-27 21:02:16] Torbutton DBUG: setting panel style: text
[02-27 21:02:16] Torbutton DBUG: called update_status: true,false
[02-27 21:02:16] Torbutton DBUG: Toggling JS state
[02-27 21:02:16] Torbutton DBUG: Setting user agent
[02-27 21:02:16] Torbutton DBUG: Done with user agent: false
[02-27 21:02:16] Torbutton DBUG: Children: 6
[02-27 21:02:16] Torbutton DBUG: Children: network.protocol-handler.warn-external.mailto
[02-27 21:02:16] Torbutton DBUG: Children: network.protocol-handler.warn-external.file
[02-27 21:02:16] Torbutton DBUG: Children: network.protocol-handler.warn-external.snews
[02-27 21:02:16] Torbutton DBUG: Children: network.protocol-handler.warn-external.news
[02-27 21:02:16] Torbutton DBUG: Children: network.protocol-handler.warn-external-default
[02-27 21:02:16] Torbutton DBUG: Children: network.protocol-handler.warn-external.nntp
[02-27 21:02:16] Torbutton DBUG: called torbutton_clear_history
[02-27 21:02:16] Torbutton DBUG: Clearing browser session history
[02-27 21:02:16] Torbutton DBUG: Prefs pretty much done
[02-27 21:02:16] Torbutton INFO: Disabled livemarks
[02-27 21:02:18] Torbutton DBUG: Got cookie pref change
[02-27 21:02:21] Torbutton DBUG: called update_status: true,false
[02-27 21:02:21] Torbutton DBUG: Toggling JS state
[02-27 21:02:21] Torbutton DBUG: Setting user agent
[02-27 21:02:21] Torbutton DBUG: Done with user agent: false
[02-27 21:02:21] Torbutton DBUG: Children: 6
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.mailto
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.file
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.snews
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.news
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external-default
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.nntp
[02-27 21:02:21] Torbutton DBUG: called torbutton_clear_history
[02-27 21:02:21] Torbutton DBUG: Clearing browser session history
[02-27 21:02:21] Torbutton DBUG: Prefs pretty much done
[02-27 21:02:21] Torbutton INFO: Disabled livemarks
[02-27 21:02:21] Torbutton DBUG: called update_status: true,false
[02-27 21:02:21] Torbutton DBUG: Toggling JS state
[02-27 21:02:21] Torbutton DBUG: Setting user agent
[02-27 21:02:21] Torbutton DBUG: Done with user agent: false
[02-27 21:02:21] Torbutton DBUG: Children: 6
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.mailto
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.file
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.snews
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.news
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external-default
[02-27 21:02:21] Torbutton DBUG: Children: network.protocol-handler.warn-external.nntp
[02-27 21:02:21] Torbutton DBUG: called torbutton_clear_history
[02-27 21:02:22] Torbutton DBUG: Clearing browser session history
[02-27 21:02:22] Torbutton DBUG: Prefs pretty much done
[02-27 21:02:22] Torbutton INFO: Disabled livemarks
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: Toggling JS state
[02-27 21:02:22] Torbutton DBUG: Setting user agent
[02-27 21:02:22] Torbutton DBUG: Done with user agent: false
[02-27 21:02:22] Torbutton DBUG: Children: 6
[02-27 21:02:22] Torbutton DBUG: Children: network.protocol-handler.warn-external.mailto
[02-27 21:02:22] Torbutton DBUG: Children: network.protocol-handler.warn-external.file
[02-27 21:02:22] Torbutton DBUG: Children: network.protocol-handler.warn-external.snews
[02-27 21:02:22] Torbutton DBUG: Children: network.protocol-handler.warn-external.news
[02-27 21:02:22] Torbutton DBUG: Children: network.protocol-handler.warn-external-default
[02-27 21:02:22] Torbutton DBUG: Children: network.protocol-handler.warn-external.nntp
[02-27 21:02:22] Torbutton DBUG: called torbutton_clear_history
[02-27 21:02:22] Torbutton DBUG: Clearing browser session history
[02-27 21:02:22] Torbutton DBUG: Prefs pretty much done
[02-27 21:02:22] Torbutton INFO: Disabled livemarks
[02-27 21:02:22] Torbutton DBUG: Activate tor settings
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: called update_status: true,false
[02-27 21:02:22] Torbutton DBUG: socks_remote_dns is available
[02-27 21:02:22] Torbutton DBUG: Done activating tor settings

comment:8 Changed 9 years ago by stealth

Which torbutton perference are you guys actually changing?

It's not necessary to change a preference. Opening the prefs and clicking "Okay" triggers it. In my case, it raises eight warning messages, the number of security tabs. Is that a coincidence?

comment:9 Changed 9 years ago by mikeperry

Jon - Are you using useragentswitcher or any other addons that change Firefox settings?

comment:10 Changed 9 years ago by mikeperry

This is definitely an addon conflict issue. I have tried changing several settings and I only get a popup
once.

I am going to need some more help to figure this out.

Please tell me what other addons you have running, your current tor state, and what options (if any) you have
recently changed.

comment:11 Changed 9 years ago by mikeperry

Also, please tell me how often this happens.

Is it something that only happens once in a while, or does it happen every single time you toggle tor, or does
it happen every single time you open the prefs window? Does it even happen if you press cancel?

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre3.xpi added

comment:12 Changed 9 years ago by mikeperry

Ok, please try the torbutton-1.2.5pre3.xpi in the attachments tab. It is a hack that forces the dialog to
only appear once no matter what happens. I really wish I could figure out why it was happening in the first
place though.

Please let me know if the fix works for you guys.

comment:13 Changed 9 years ago by stealth

Mike - Torbutton is the only addon I am using at this time. Where can I find 1.2.5?

comment:14 Changed 9 years ago by mikeperry

"Please try the torbutton-1.2.5pre3.xpi in the attachments tab."

https://bugs.torproject.org/flyspray/index.php?do=details&id=1219&area=attachments#tabs

comment:15 Changed 9 years ago by mikeperry

Description: modified (diff)
Resolution: Nonefixed
Status: newclosed

Fixed in 1.2.5.

Note: See TracTickets for help on using tickets.