Opened 5 years ago

Last modified 4 months ago

#12190 new defect

Pyptlib does not join args or optargs correctly in ClientTransportPlugin.reportMethodSuccess

Reported by: RushingWookie Owned by:
Priority: Low Milestone:
Component: Circumvention/Pluggable transport Version:
Severity: Normal Keywords: pyptlib, ClientTransportPlugin, ReportMethodSuccess
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In ClientTransportPlugin.reportMethodSuccess, the code for joining the params args and optargs is wrong. The args and optargs params are defined as strings when they should be lists of strings.
Current code

        if args and len(args) > 0:
          methodLine = methodLine + ' ARGS=' + args.join(',')
        if optArgs and len(optArgs) > 0:
          methodLine = methodLine + ' OPT-ARGS=' + args.join(',')

Fixed Code

        if args and len(args) > 0:
          methodLine = methodLine + ' ARGS=' + ','.join(args)
        if optArgs and len(optArgs) > 0:
          methodLine = methodLine + ' OPT-ARGS=' + ','.join(optArgs)

Also the documentation for the types of args and optArgs should be changed to lists.

Child Tickets

Change History (3)

comment:1 Changed 18 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:2 Changed 4 months ago by teor

Owner: asn deleted
Status: newassigned

asn does not need to own any obfuscation tickets any more. Default owners are trouble.

comment:3 Changed 4 months ago by cohosh

Status: assignednew

tickets were assigned to asn, setting them as unassigned (new) again.

Note: See TracTickets for help on using tickets.