Opened 5 years ago

Closed 5 years ago

#12194 closed defect (fixed)

rend_client_note_connection_attempt_ended() gets called redundantly

Reported by: andrea Owned by:
Priority: Low Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.4-alpha
Severity: Keywords: tor-hs 026-triaged-1 026-deferrable easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When hidden service connection attempts fail, rend_client_note_connection_attempt_ended() can get called once from connection_mark_unattached_ap() and then again from rend_client_desc_trynow() after it returns. See the log snippet in #10616 for an example.

Child Tickets

Change History (6)

comment:1 Changed 5 years ago by nickm

Keywords: tor-hs 026-triaged-1 026-deferrable easy added

comment:2 Changed 5 years ago by andrea

Status: newneeds_review

Proposed fix in my bug12194 branch.

comment:3 Changed 5 years ago by nickm

Looks plausible to me. How did you test this?

Would it be simpler just to explicitly say that rend_client_note_connection_attempt_ended is supposed to be idempotent?

comment:4 Changed 5 years ago by andrea

Yeah, declaring rend_client_note_connection_attempt_ended() idempotent and making a comment on it to that effect in case of future modifications would be an acceptable alternative, I think.

comment:5 Changed 5 years ago by andrea

See my bug12194_alt branch.

comment:6 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged!

Note: See TracTickets for help on using tickets.