Opened 5 years ago

Closed 5 years ago

#12210 closed enhancement (fixed)

Display comment when chat session begins

Reported by: lunar Owned by: Sherief
Priority: Low Milestone:
Component: User Experience/Tor Support Version:
Severity: Keywords: pups
Cc: sherief Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When a user invited to a chat session logs in, the token is currently sent to the support assistant. It would be great to also send the associated comment as it will often contains some context about what the user needs.

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by Sherief

Owner: changed from lunar to Sherief
Status: newaccepted

comment:2 Changed 5 years ago by Sherief

Resolution: fixed
Status: acceptedclosed
Last edited 5 years ago by Sherief (previous) (diff)

comment:3 Changed 5 years ago by Sherief

Resolution: fixed
Status: closedreopened

comment:4 Changed 5 years ago by Sherief

Status: reopenedneeds_review

comment:5 Changed 5 years ago by Sherief

Status: needs_reviewneeds_revision

I did some improvements on this, for example: now webchat sends the username, comment and token id to the support assistant without displaying them in the user's UI.

The above commits are now one and improved:
https://github.com/SheriefAlaa/projectpups/commit/90d13a33903abdc1f5943643675ebcd1362f27ea

comment:6 Changed 5 years ago by lunar

Please use topic branch in the future. E.g. “bug12210”.

+ toAssistant = typeof toAssistant == 'undefined' ? false : true;

Mh… Why do you need to spell boolean values explicitely?

- 'token': " Token: " + Prodromus.config.TOKEN

Like last time. This is an array with strings for translation. You can't put dynamic content in it like that.

comment:7 in reply to:  6 ; Changed 5 years ago by Sherief

Status: needs_revisionneeds_review

Replying to lunar:

Please use topic branch in the future. E.g. “bug12210”.

+ toAssistant = typeof toAssistant == 'undefined' ? false : true;

Mh… Why do you need to spell boolean values explicitely?

You are absolutely right, this line was completely unnecessary. Fixed in:
https://github.com/SheriefAlaa/pups/commit/93196c65a5619adbb29477c882d0e60756f2681e

- 'token': " Token: " + Prodromus.config.TOKEN

Like last time. This is an array with strings for translation. You can't put dynamic content in it like that.

Exactly, I am removing not adding. The thing is that I can't remove the addition from history because it's already on tpo/pups.git/master.

comment:8 in reply to:  7 Changed 5 years ago by lunar

Replying to Sherief:

Replying to lunar:

- 'token': " Token: " + Prodromus.config.TOKEN

Like last time. This is an array with strings for translation. You can't put dynamic content in it like that.

Exactly, I am removing not adding. The thing is that I can't remove the addition from history because it's already on tpo/pups.git/master.

Oh my, I read the patch wrong. Please accept my apologies.

comment:9 Changed 5 years ago by lunar

Resolution: fixed
Status: needs_reviewclosed

Merged as part as the sherief/webchat_patches.

Note: See TracTickets for help on using tickets.