toolbar_button.js should do more null checks

I have installed it on WinXP, Win7, Linux(Ubuntu) in Firefox 29.0.1. On XP, I see a long list of rules in the preferences screen. On Win7 and Linux, the rule list is empty. I have tried reinstalling and restarting, but to no avail. I can't tell if it's actually doing anything or not without any rulesets...

added component::https everywhere/eff-https everywhere owner::zyan priority::low resolution::fixed rulesets severity::normal status::closed type::defect labels

Trac:
Owner: N/A to zyan
Component: - Select a component to EFF-HTTPS Everywhere

I think we fixed this in 3.5.1.

You can test if rewrites are happening by going to a site like http://apple.com (will be HTTPS if you have HTTPS everywhere installed and running and haven't disabled the apple rule).

Trac:
Status: new to needs_information

I'm having this same issue in Firefox 30 and 31, Windows 7 64-bit. Tried both latest-stable, 3.5.3, and 4.0-development-17. The list is empty, and apple.com does not redirect me to https.

This used to work in the past, I'm not sure exactly when it broke. Anything I can do to help debug it?

Trac:
Username: matiash

!!

Does this work in Firefox 29?

Can you go to your Firefox profile folder (see https://support.mozilla.org/en-US/kb/profiles-where-firefox-stores-user-data#w_how-do-i-find-my-profile), and see if ./extensions/https-everywhere@eff.org/defaults/rulesets.sqlite exists?

Also you can try going to about:config and setting extensions.https_everywhere.LogLevel to 2, restarting Firefox, and saving the console output.

The sqlite file is indeed there. But from the log, I think I found the cause. It said:

TypeError: toolbarbutton is null toolbar_button.js:133 TypeError: popup is null toolbar_button.js:234 TypeError: popup is null toolbar_button.js:234

I had customized the Firefox toolbar to remove the HTTPS Everywhere icon. When I added it again, it started working.

From my side the issue is resolved, but if you need anything else I'd be glad to help.

Trac:
Username: matiash

I tried to reproduce this on Firefox 31.0. I installed HTTPS Everywhere, restarted, customized the toolbar to remove the HTTPS Everywhere icon, and restarted. I was still able to visit e.g. httP://www.openssl.org, and get redirected by the extension to HTTPS.

I'm not sure what's going on, but I do notice a few places in toolbar_button.js that could you some protective null checks. I'm going to downgrade priority and rename.

Trac:
Priority: critical to minor
Status: needs_information to needs_revision
Summary: No rules show up after installing HTTPS Everywhere to toolbar_button.js should do more null checks

Trac:
Cc: jrw32982@yahoo.com to jrw32982@yahoo.com, brade, mcs, gk

Trac:
0001-Bug-12218-toolbar_button.js-should-do-more-null-chec.patch

a possible fix

Kathy Brade and I saw various errors on the Browser Console when testing Tor Browser 4.5a5 that have their origin in HTTPS Everywhere (all were related to no toolbar item being present). The patch that I just attached fixes all of them for us, including the one described in #13550 (moved).

Trac:
Status: needs_revision to needs_review

Hey mcs, the patch looks good but please use curly braces around all blocks.

Also, if you don't mind submitting the patch as a Github pull request, that would be preferred. https://github.com/efforg/https-everywhere/pulls

BTW, I am no longer officially working for EFF/Tor, so I generally don't see email notifications for tickets owned by this account. The active maintainers mostly use Github, I think.

Replying to zyan:

Hey mcs, the patch looks good but please use curly braces around all blocks.

Fixed.

Also, if you don't mind submitting the patch as a Github pull request, that would be preferred. https://github.com/efforg/https-everywhere/pulls

Done. Thanks for pointing me in the right direction for patch submission.

Set all open tickets without a severity to "Normal"

Trac:
Severity: N/A to Normal

Looks like it's been fixed on the deprecated XUL/XPCOM, we're on the WebExtension now anyway.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed
Reviewer: N/A to N/A
Sponsor: N/A to N/A

closed

mentioned in issue #13550 (moved)

moved to tpo/applications/https-everywhere-eff#12218 (closed)