Opened 6 years ago

Closed 5 years ago

#12219 closed defect (fixed)

Clean dead code from entrynodes.c

Reported by: asn Owned by:
Priority: Very Low Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-guard, 026-triaged-1
Cc: Actual Points:
Parent ID: #11480 Points:
Reviewer: Sponsor:

Description

I see dead code in entrynodes.c.

There are three blocks of #if 0 code. One of them is particularly annoying because it's in the middle of choose_random_entry_impl() which is an important function, and it makes it harder to read.

I would say that all dead code needs to go to the graveyard (git history in our case).

(We might want to keep the dead code in control_event_guard_deferred(), which is currently a NOP, just to show what that function used to be.)

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by nickm

Keywords: 026 added
Parent ID: #11480

comment:2 Changed 5 years ago by nickm

Keywords: 026-triaged-1 added; 026 removed

comment:3 Changed 5 years ago by asn

Downgrading to the ?? milestone because of low importance.

Also might be fixed during #12207 anyway.

comment:4 Changed 5 years ago by asn

Resolution: fixed
Status: newclosed

Dead code cleaned during #12207.
Closing this ticket :)

Note: See TracTickets for help on using tickets.