Opened 6 years ago

Closed 5 years ago

#12238 closed defect (fixed)

Make Linux bundles built with LXC match their KVM counterparts

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: gitian, tbb-gitian
Cc: Actual Points:
Parent ID: #12237 Points:
Reviewer: Sponsor:

Description

The differences between LXC and KVM built Linux bundles are in libgmp.so and libgmpxx.so.

Child Tickets

Attachments (1)

libgmp_diff.bz2 (1000.1 KB) - added by gk 6 years ago.
libgmp KVM and LXC diff when building TBB 3.6.2

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by gk

Attachment: libgmp_diff.bz2 added

libgmp KVM and LXC diff when building TBB 3.6.2

comment:1 Changed 6 years ago by gk

Note: this did not happen on the LXC setup Mike used (but the one in use by Nicolas).

comment:2 Changed 5 years ago by erinn

Component: Tor bundles/installationTor Browser
Keywords: tbb-gitian added
Owner: changed from erinn to tbb-team

comment:3 Changed 5 years ago by gk

Happens on my local machine, too.

comment:4 Changed 5 years ago by lunar

The differences happen because the ./configure script will detect different CPUs and use different compiler optimizations depending on that. Which actually makes me wonder if this should not be built using the --enable-fat option so optimizations for all kind of processors are built-in. I'll do more tests.

comment:5 Changed 5 years ago by lunar

Ok, I confirm that the content of gmp-5.1.3-linux32-utils.zip and gmp-5.1.3-linux64-utils.zip become identical when --enable-fat is added.

comment:6 Changed 5 years ago by lunar

The build for OS X fails with --enable-fat.

comment:7 Changed 5 years ago by lunar

But I confirm there's no differences in what gmp builds for mac32, be it with LXC or KVM.

comment:8 Changed 5 years ago by gk

Resolution: fixed
Status: newclosed

Fix with commit 2d063903ba6fac309ee367fe397bc53c972c29cc, thanks!

Note: See TracTickets for help on using tickets.