Make Mac bundles built with LXC match their KVM counterparts

There seem to be extensive differences in __m2crypto.so. Mike reports that the OpenSSL input ends up different between LXC and KVM. Might be a first starting point in fixing the problem.

added component::applications/tor browser gitian owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-gitian type::defect labels

Trac:
Component: Tor bundles/installation to Tor Browser
Owner: erinn to tbb-team
Keywords: N/A deleted, tbb-gitian added

openssl-i.0.1i-mac32-utils.zip indeed came up differently between LXC and KVM. The only differences are in libcrypto.a.

I'm assuming the the symbol table is different because the offsets of the members are different.

The offsets differ because some members get added with their name using the long filename trick. The member length itself differs once in a while for (I assume) alignment purposes.

It seems to happen because of “clock skew” issues. Some members get built and added twice to archive. That seems to match the long filenames headers.

Confirmed. If I unset LD_PRELOAD to disable libfaketime, the build logs are nearly identical. libcrypto.a is left with only timestamp related differences. The one in headers can be removed using strip-nondeterminism but there's another timestamp coming from crypto/Makefile:buildinf.h.

I think I have a fix for this. It is in my bug_12240_4 branch (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_12240_4) and up for review.

Trac:
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201508R added

r=mcs I have not tested this, but the changes look OK.

Thanks, let's call this closed then and try it in an alpha for realz (commit b8633570c5ae6b2881096e318889c335c958e1c2 is the fix).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

We're going to revert this temporarily to save time on rebuilding 5.5a2. Reopening so we remember to reapply after 5.5a2 is out.

Trac:
Status: closed to reopened
Resolution: fixed to N/A
Parent: #12237 (moved) to N/A

This is now fixed in commit a640b2e3c2d58f89880350bdee883f7f1d2f90be on master.

Trac:
Resolution: N/A to fixed
Status: reopened to closed

It seems I forgot the __m2crypto.so portion of this ticket.

Trac:
Resolution: fixed to N/A
Status: closed to reopened

Trac:
Keywords: TorBrowserTeam201508R deleted, TorBrowserTeam201510 added
Sponsor: N/A to N/A

No time for these during October.

Trac:
Keywords: TorBrowserTeam201510 deleted, N/A added

We are building release builds on LXC machines for a while now and it works.

Trac:
Resolution: N/A to fixed
Status: reopened to closed
Severity: N/A to Normal
Reviewer: N/A to N/A

closed

mentioned in issue #15578 (moved)

mentioned in issue #16900 (moved)

mentioned in issue #17428 (closed)

moved to tpo/applications/tor-browser#12240 (closed)