Opened 6 years ago

Closed 6 years ago

#12382 closed defect (wontfix)

Changed upstream langpack xpis prevent reproducibility of 3.6.2

Reported by: dcf Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords: tbb-3.6
Cc: mikeperry, gk, brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Mozilla tagged an esr24 release after the release of TBB 3.6.2. In doing so, they rezipped the langpack xpis. Now the langpacks used to build 3.6.2 are apparently lost.

TBB 3.6.2 was built on or before June 9:
Mozilla committed something on June 10:
Now, the modification date of the langpacks is June 10:

I noticed this after rebuilding the 3.6.2-meek-1 bundles. I have one build from June 9, and one from June 12. The en-US files match, but all the other languages do not match. Inside a pair of non-matching, files, the only file that differs is Data/Browser/profile.default/extensions/langpack-lang‍ The two xpi files have the same contents when unzipped, but are not the same file and have different embedded timestamps.

Child Tickets

Attachments (2) (315.7 KB) - added by dcf 6 years ago.
Langpack from June 9. (315.7 KB) - added by dcf 6 years ago.
Langpack from June 12.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by dcf

Langpack from June 9.

Changed 6 years ago by dcf

Langpack from June 12.

comment:1 Changed 6 years ago by mcs

Cc: brade mcs added

comment:2 Changed 6 years ago by mcs

As I mentioned during the TBB dev meeting, brade and I encountered this same problem. We could re-dzip each langpack XPI after we fetch it, but it is still possible that Mozilla will change something if they make a habit of re-pushing releases. I would not expect them to do so very often though.

Actually, it surprises me that we can reliably fetch the langpacks the way we do; what if we release before Mozilla does? Will the langpacks be available under ?

comment:3 Changed 6 years ago by erinn

Keywords: needs-triage added

comment:4 Changed 6 years ago by gk

Keywords: needs-triage removed
Resolution: wontfix
Status: newclosed

I think we WONTFIX this for 3.6.2 but the issue should go away with the fix landed in commit 2da330af506d344e97b8d192a512c4c7df4a663e. There we take the candidate builds and changing xpis etc. later does not bother us. This has its drawbacks, too, of course. :)

Note: See TracTickets for help on using tickets.