Opened 5 years ago

Last modified 22 months ago

#12399 new defect

"Hash of session info was not as expected" should be log_protocol_warn

Reported by: ln5 Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs easy logging
Cc: Actual Points:
Parent ID: Points: .1
Reviewer: Sponsor:

Description

Seeing

[warn] Hash of session info was not as expected.

on fast relays, both exits and non exits (ndnr1, DFRI0, DFRI2) several times today. First one spotted at Jun 14 00:26 CEST.

These are on Linux and FreeBSD, versions 0.2.5.4-alpha-dev and 0.2.5.2-alpha respectively.

Child Tickets

Change History (11)

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-final

comment:2 Changed 5 years ago by arma

Comes from

/** Respond to an ESTABLISH_INTRO cell by checking the signed data and
 * setting the circuit's purpose and service pk digest.
 */
int
rend_mid_establish_intro()
  if (tor_memneq(expected_digest, request+2+asn1len, DIGEST_LEN)) {
    log_warn(LD_PROTOCOL, "Hash of session info was not as expected.");
    reason = END_CIRC_REASON_TORPROTOCOL;

Sounds like somebody somewhere in the world is working on implementing hidden service client support, and didn't do it right in this case.

The simple fix is to make this a LOG_PROTOCOL_WARN so it doesn't bother normal operators with bugs on the client side.

Another option though is that there actually is a bug in the mainline Tor client.

comment:3 Changed 5 years ago by nickm

Keywords: 025-backport added
Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final

comment:4 Changed 5 years ago by ln5

FWIW, I haven't seen this since Jun 20. Someone tried something for six days?

comment:5 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

comment:6 Changed 4 years ago by Sebastian

Saw this on my relay today.

comment:7 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:8 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:9 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:10 Changed 22 months ago by nickm

Keywords: 025-backport removed

These are not ripe for 0.2.5, even if they do get fixed now

comment:11 Changed 22 months ago by nickm

Keywords: tor-hs easy logging added
Points: .1
Severity: Normal
Summary: Hash of session info was not as expected"Hash of session info was not as expected" should be log_protocol_warn

The right fix, given the timeline, is probably "log_protocol_warn".

Note: See TracTickets for help on using tickets.