Opened 5 years ago

Closed 5 years ago

#12403 closed defect (fixed)

Support [SP|TAB]+ between keyword and argument, not just SP

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Library Version:
Severity: Keywords:
Cc: atagar, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There are new sightings of #6350 (see the two SP in line 2):

0000000: 6578 7472 612d 696e 666f 206b 7279 6b79  extra-info kryky
0000010: 726c 2020 4346 4433 3546 3130 4332 3446  rl  CFD35F10C24F
0000020: 3736 3244 3545 4434 3444 4541 3645 4544  762D5ED44DEA6EED
0000030: 3135 3335 4641 4338 3730 3237 0a70 7562  1535FAC87027.pub
0000040: 6c69 7368 6564 2032 3031 342d 3036 2d31  lished 2014-06-1
0000050: 3520 3138 3a30 343a 3139 0a72 6f75 7465  5 18:04:19.route
0000060: 722d 7369 676e 6174 7572 650a 2d2d 2d2d  r-signature.----
0000070: 2d42 4547 494e 2053 4947 4e41 5455 5245  -BEGIN SIGNATURE
0000080: 2d2d 2d2d 2d0a 5545 3757 7177 424b 786d  -----.UE7WqwBKxm
0000090: 7431 5841 666f 6c58 3439 444e 6c65 7574  t1XAfolX49DNleut
00000a0: 3337 2b6b 576c 6663 6d70 5044 7669 4e4b  37+kWlfcmpPDviNK
00000b0: 4551 3837 3830 5145 4259 7434 3243 656c  EQ8780QEBYt42Cel
00000c0: 6564 4732 5245 0a2f 7734 4f35 4e53 3759  edG2RE./w4O5NS7Y
00000d0: 524d 5635 5950 3435 4354 6f41 5546 4d2f  RMV5YP45CToAUFM/
00000e0: 4f74 2f50 7858 6751 4f65 6f42 4f6a 776c  Ot/PxXgQOeoBOjwl
00000f0: 7836 4b38 6f71 5a72 3234 5562 7042 3473  x6K8oqZr24UbpB4s
0000100: 6d35 4f37 5179 660a 3857 6e57 3352 314f  m5O7Qyf.8WnW3R1O
0000110: 4334 6c4d 3169 7349 796a 7a53 3863 7044  C4lM1isIyjzS8cpD
0000120: 7668 4c39 7355 6457 6e59 5774 3737 4c72  vhL9sUdWnYWt77Lr
0000130: 366c 413d 0a2d 2d2d 2d2d 454e 4420 5349  6lA=.-----END SI
0000140: 474e 4154 5552 452d 2d2d 2d2d 0a         GNATURE-----.

CollecTor is currently not storing these descriptors, because it can't parse them. I should teach metrics-lib really soon that they are valid. Raising priority to critical. Hoping to do this tomorrow.

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by karsten

Another example, this time a server descriptor:

0000000: 4075 706c 6f61 6465 642d 6174 2032 3031  @uploaded-at 201
0000010: 342d 3036 2d31 3520 3138 3a30 363a 3439  4-06-15 18:06:49
0000020: 0a40 736f 7572 6365 2022 3738 2e33 302e  .@source "78.30.
0000030: 3139 322e 3232 3922 0a72 6f75 7465 7220  192.229".router 
0000040: 6b72 796b 7972 6c20 2037 382e 3330 2e31  krykyrl  78.30.1
0000050: 3932 2e32 3239 2039 3235 3220 3020 300a  92.229 9252 0 0.
0000060: 706c 6174 666f 726d 2054 6f72 2030 2e32  platform Tor 0.2
0000070: 2e34 2e31 372d 7263 206f 6e20 5769 6e64  .4.17-rc on Wind
0000080: 6f77 7320 224c 6f6e 6768 6f72 6e22 2053  ows "Longhorn" S
0000090: 6572 7669 6365 2050 6163 6b20 3220 5b73  ervice Pack 2 [s
00000a0: 6572 7665 725d 207b 2262 6c61 6465 2220  erver] {"blade"
...

Both descriptors were uploaded to and accepted by gabelmoo.

Also emailing the operator and asking them for their torrc.

comment:2 Changed 5 years ago by karsten

Priority: criticalnormal

Implemented and deployed a hot fix for this specific case. Leaving this open, but at normal priority, to make the fix more general and add unit tests.

comment:3 Changed 5 years ago by karsten

Resolution: fixed
Status: newclosed

Implemented and deployed a more general fix, and included unit tests. Closing.

Note: See TracTickets for help on using tickets.