Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#12503 closed defect (fixed)

fgets test gets skipped

Reported by: cypherpunks Owned by:
Priority: Low Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.3.25
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The test for how fgets handles non-blocking pipes is skipped because it apparently fails.

Included are two patches for consideration;

  • 0001 fixes the test by checking its behavior as discussed in #1903, #2045, and described by the C99 and C11 standards.
  • 0002 uses the test_* macros which the majority of the other tests use. I'm not sure if the tt_* or the test_* functions are preferred.

Child Tickets

Attachments (2)

0001-Fixed-fgets_eagain-unit-test.patch (4.1 KB) - added by cypherpunks 6 years ago.
0002-Use-test_-macros-instead-of-the-standard-tinytest-fu.patch (3.6 KB) - added by cypherpunks 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by cypherpunks

comment:1 Changed 6 years ago by nickm

Keywords: tor-client added
Milestone: Tor: 0.2.5.x-final
Status: newneeds_review

tt_* is preferred; test_* is the old one.

The first patch should get reviewed though.

comment:2 Changed 6 years ago by nickm

Applying the first patch to master for 0.2.6 . Thanks!

comment:3 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

comment:4 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final
Note: See TracTickets for help on using tickets.