Opened 6 years ago

Closed 5 years ago

#12509 closed defect (fixed)

Setting an option clears addressmappings, automapped addresses

Reported by: epoch Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.5.5-alpha
Severity: Keywords: Automapping, dnsport, cookieauthenticataion, 025-backport 026-triaged-1
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

starting tor with:

tor --DNSPort 9053 --Log "notice syslog" --CookieAuthentication 1

then running:

echo -e 'Authenticate '$(cat /var/tor/control_auth_cookie | xxd -p | tr -d '\n')'\nSetConf Log="notice syslog"' | ncat 127.0.0.1 9051

clears all addressmappings and makes queries to DNSPort stop responding with automapped addresses.

Child Tickets

Change History (10)

comment:1 Changed 6 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.6.x-final
Summary: Really weird.Setting an option clears addressmappings, automapped addresses

comment:2 Changed 6 years ago by nickm

Keywords: 025-backport added; removed

comment:3 Changed 6 years ago by nickm

Keywords: 026-triaged-1 added

comment:4 Changed 6 years ago by nickm

Interestingly, it looks like any change in any option removes the nil entry from automaphostssuffixes.

comment:5 Changed 6 years ago by nickm

Status: newneeds_review

Oh, that's simple enough. See branch bug12509_025 in my public repository.

comment:6 Changed 6 years ago by rl1987

Looks good to me.

comment:7 Changed 6 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.5.x-final

comment:8 Changed 6 years ago by nickm

(merged to master, marking for possible backport)

comment:9 Changed 6 years ago by arma

I could go either way on a backport here. It looks like a piece of functionality was hugely broken, but only for a tiny number of power users.

So I guess the question is: are those power users for some reason unable to use Tor 0.2.6, or unable to know that they should?

My slight inclination is to mark this one as a major bugfix in 0.2.6, say more clearly in the changelog entry what thing would go wrong that now doesn't go wrong, and then no backport.

comment:10 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final
Resolution: fixed
Status: needs_reviewclosed

Not backporting these.

Note: See TracTickets for help on using tickets.