Tor Button does not work unless Navigation toolbar is enabled

Just letting you know that the Tor Button does not have any functionality unless the Navigation toolbar is enabled. I like to customize my layout for maximum content viewing area and I do this by dragging certain buttons off of the Navigation toolbar and putting them elsewhere. All of the other buttons seem to work fine but not the Tor Button and its most important feature, the ability to choose a New Identity.

Thanks. Tim

Trac:
Username: pursuit81

added component::applications/tor browser gitlab-tb-torbutton owner::tbb-team priority::medium reporter::pursuit81 severity::normal status::new tbb-easy tbb-torbutton tbb-usability type::defect labels

Trac:
Component: Tor to TorBrowserButton
Owner: N/A to mikeperry
Version: Tor: unspecified to N/A

What does "elsewhere" mean? Do you have some steps to reproduce your issue easily?

Trac:
Keywords: N/A deleted, tbb-usability added

When I say "elsewhere", I mean I put the button up on the Menu Bar to save space. But, as I mentioned, it does not work when there unless the Navigation Bar is also showing which, of course, defeats the purpose of putting it there in the first place. Thx.

Trac:
Username: pursuit81

Trac:
Keywords: N/A deleted, tbb-torbutton added
Owner: mikeperry to tbb-team
Component: TorBrowserButton to Tor Browser

#15222 (moved) is a duplicate (has STR).

Trac:
Severity: N/A to Normal
Sponsor: N/A to N/A
Reviewer: N/A to N/A

This problem occurs because of the following code that is in torbutton.xul:

    <toolbar id="nav-bar">
        <menupopup id="torbutton-context-menu"/>
    </toolbar>

We need to move the menupopup to an element that is always available such as the mainPopupSet.

Trac:
Keywords: N/A deleted, tbb-easy added
Cc: N/A to brade, mcs

Hey!! Can I work on this bug? I am a newbie.

Trac:
Username: aruna1234

Replying to aruna1234:

Hey!! Can I work on this bug? I am a newbie.

Go for it :)

So, I'll have to change the id to the I believe?

Trac:
Username: aruna1234

Replying to aruna1234:

So, I'll have to change the id to the I believe?

I do not think this is correct. The root cause of this bug is that the is a child of the nav-bar, which means it is not available if the Navigation Toolbar is removed from the user interface. To fix this issue, the needs to be a child of a different element, one that is always present. In comment:7 I suggested making it a child of the mainPopupSet element. You can find an example of similar code here: https://dxr.mozilla.org/mozilla-esr52/source/browser/base/content/web-panels.xul#50

Thanks for the suggestion! Will look into it! Can you give me definite steps to reproduce this bug for better understanding.

Trac:
Username: aruna1234

Could you also point to the file that needs the change?

Trac:
Username: aruna1234

So the change is required in the toolbar id then. Changing it to 'mainPopSet' should do the task?

Trac:
Username: aruna1234

Replying to aruna1234:

Can you give me definite steps to reproduce this bug for better understanding.

For steps to reproduce, see: ticket:15222#comment:2

Regarding your other questions, you may want to read up on XUL overlays, e.g., here: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Overlays

Add magic gitlab keyword.

Trac:
Keywords: N/A deleted, gitlab-tb-torbutton added

mentioned in issue #15222 (moved)

moved to tpo/applications/torbutton#12514 (closed)