Opened 5 years ago

Last modified 19 months ago

#12514 new defect

Tor Button does not work unless Navigation toolbar is enabled

Reported by: pursuit81 Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-usability, tbb-torbutton, tbb-easy
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Just letting you know that the Tor Button does not have any functionality unless the Navigation toolbar is enabled. I like to customize my layout for maximum content viewing area and I do this by dragging certain buttons off of the Navigation toolbar and putting them elsewhere. All of the other buttons seem to work fine but not the Tor Button and its most important feature, the ability to choose a New Identity.

Thanks. Tim

Child Tickets

Change History (15)

comment:1 Changed 5 years ago by gk

Component: Tor → TorBrowserButton
Owner: set to mikeperry
Version: Tor: unspecified

comment:2 Changed 5 years ago by gk

What does "elsewhere" mean? Do you have some steps to reproduce your issue easily?

comment:3 Changed 5 years ago by gk

Keywords: tbb-usability added

comment:4 Changed 5 years ago by pursuit81

When I say "elsewhere", I mean I put the button up on the Menu Bar to save space. But, as I mentioned, it does not work when there unless the Navigation Bar is also showing which, of course, defeats the purpose of putting it there in the first place. Thx.

comment:5 Changed 5 years ago by erinn

Component: TorBrowserButton → Tor Browser
Keywords: tbb-torbutton added
Owner: changed from mikeperry to tbb-team

comment:6 Changed 3 years ago by bugzilla

Severity: → Normal

#15222 is a duplicate (has STR).

comment:7 Changed 3 years ago by mcs

Cc: brade mcs added
Keywords: tbb-easy added

This problem occurs because of the following code that is in torbutton.xul: 

    <toolbar id="nav-bar">
        <menupopup id="torbutton-context-menu"/>
    </toolbar>

We need to move the menupopup to an element that is always available such as the mainPopupSet.

comment:8 Changed 19 months ago by aruna1234

Hey!! Can I work on this bug? I am a newbie.

comment:9 in reply to:  8 Changed 19 months ago by cypherpunks

Replying to aruna1234:

Hey!! Can I work on this bug? I am a newbie.

Go for it :)

comment:10 Changed 19 months ago by aruna1234

So, I'll have to change the <menupopup id="torbutton-context-menu"/> id to the <menuPopupSet id="torbutton-context-menu"/> I believe?

comment:11 in reply to:  10 Changed 19 months ago by mcs

Replying to aruna1234:

So, I'll have to change the <menupopup id="torbutton-context-menu"/> id to the <menuPopupSet id="torbutton-context-menu"/> I believe?

I do not think this is correct. The root cause of this bug is that the <menupopup> is a child of the nav-bar, which means it is not available if the Navigation Toolbar is removed from the user interface. To fix this issue, the <menupopup> needs to be a child of a different element, one that is always present. In comment:7 I suggested making it a child of the mainPopupSet element. You can find an example of similar code here:
​https://dxr.mozilla.org/mozilla-esr52/source/browser/base/content/web-panels.xul#50

comment:12 Changed 19 months ago by aruna1234

Thanks for the suggestion! Will look into it!
Can you give me definite steps to reproduce this bug for better understanding.

comment:13 Changed 19 months ago by aruna1234

Could you also point to the file that needs the change?

comment:14 Changed 19 months ago by aruna1234

So the change is required in the toolbar id then. Changing it to 'mainPopSet' should do the task?

comment:15 in reply to:  12 Changed 19 months ago by mcs

Replying to aruna1234:

Can you give me definite steps to reproduce this bug for better understanding.

For steps to reproduce, see: ticket:15222#comment:2

Regarding your other questions, you may want to read up on XUL overlays, e.g., here: ​https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Overlays

Note: See TracTickets for help on using tickets.