Changes between Version 2 and Version 3 of Ticket #12538, comment 64


Ignore:
Timestamp:
Nov 3, 2015, 2:32:01 PM (4 years ago)
Author:
nickm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12538, comment 64

    v2 v3  
    66
    77`05f95c8ec50b81ff6e7a7b3cc09f51971fd4f14d  A relay now advertises "tunnelled-dir-server" in its descriptor`
    8    * The new warning in `directory_initiate_command_rend()` should be LD_BUG.
     8   * [FIXED] The new warning in `directory_initiate_command_rend()` should be LD_BUG.
    99   * ~~'''CHECK''': There should be no more instances of DirPort_set!  Grep, just in case.~~ (Yes, looks okay. The remaining instances seem fine.)
    1010   * I worry about the definition of dir_server_mode().  Possibly, if we have advertised that we're a dirserver, we should actually be a dirserver?
    11    * The check for dir_server_mode(options) in router_dump_to_string() is wrong: we should be looking at `router->supports_tunneled_dir_requests`, not at our configuration.  We should set that field based on our actual settings in `router_build_fresh_descriptor()`.
     11   * [FIXED] The check for dir_server_mode(options) in router_dump_to_string() is wrong: we should be looking at `router->supports_tunneled_dir_requests`, not at our configuration.  We should set that field based on our actual settings in `router_build_fresh_descriptor()`.
    1212   * ~~Are we making sure to download information and be a directory cache whenever dir_server_mode() is true?~~ (Yes, because directory_caches_dir_info() already calls dir_server_mode().)
    1313
     
    4040   * looks ok.
    4141`239be79713ac388861728bc1a09f815bf348eddd  Automatically generate md-con method vers in test`
    42    * Memory leak here?
     42   * [FIXED] Memory leak here?
    4343`8cd810633a8cf8a911bc652c6d405608c04bfe58  Assert rs are added in con and con_md tests`
    4444   * Looks ok.