Opened 9 years ago

Last modified 7 years ago

#1256 closed defect (Fixed)

Check for NULL before referencing hop->extend_info, not after

Reported by: ekir Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version: 0.2.1.22
Severity: Keywords:
Cc: ekir, nickm, Sebastian, arma Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Dereference before checking for NULL.

circuitbuild.c:1112,1118

if (!hop)

break;

id = hop->extend_info->identity_digest;
if (!verbose && hop->state != CPATH_STATE_OPEN)

break;

if (!hop->extend_info)

break;

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by Sebastian

Seems pretty clear how it happened.

Branch bug1256 in my repo.

comment:2 Changed 9 years ago by arma

Since the fix is in 0.2.1.25, I'm going to close.

comment:3 Changed 9 years ago by arma

flyspray2trac: bug closed.

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.