Opened 10 years ago

Last modified 8 years ago

#1256 closed defect (Fixed)

Check for NULL before referencing hop->extend_info, not after

Reported by: ekir Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: ekir, nickm, Sebastian, arma Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Dereference before checking for NULL.


if (!hop)


id = hop->extend_info->identity_digest;
if (!verbose && hop->state != CPATH_STATE_OPEN)


if (!hop->extend_info)


[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (4)

comment:1 Changed 10 years ago by Sebastian

Seems pretty clear how it happened.

Branch bug1256 in my repo.

comment:2 Changed 10 years ago by arma

Since the fix is in, I'm going to close.

comment:3 Changed 10 years ago by arma

flyspray2trac: bug closed.

comment:4 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.