Opened 4 years ago

Closed 4 years ago

#12591 closed enhancement (implemented)

Lcov coverage reports

Reported by: daube Owned by: <default>
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: coverage
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I've implemented a makefile target to generate pretty html output as discussed from [0] on tor-dev. This target basically resets any coverage files, runs ./src/test/test (only) and then generates lcov's internal coverage report, followed by genhtml's HTML coverage report. I've also added a stanza on using lcov via this make target to doc/HACKING.

The implementation of coverage diffs using lcov is something I'm investigating, and will post back here when I have further progress. Initially, i'll just implement the kludge the lcov mailing list via Nick suggests at [1].

[0]: https://lists.torproject.org/pipermail/tor-dev/2014-June/007005.html
[1]: https://lists.torproject.org/pipermail/tor-dev/2014-June/007035.html

Cheers,
daube

Child Tickets

Attachments (1)

lcov-autotools.patch (2.8 KB) - added by daube 4 years ago.

Download all attachments as: .zip

Change History (2)

Changed 4 years ago by daube

Attachment: lcov-autotools.patch added

comment:1 Changed 4 years ago by nickm

Milestone: Tor: 0.2.6.x-final
Resolution: implemented
Status: newclosed

This looks good to me. I have merged it to master, and made some tweaks for safety and correctness as 98541f2892335a5a512a6c01b2f2227bde1d649e ; let me know if they don't look good to you.

Note: See TracTickets for help on using tickets.