Snippets Groups Projects

This is an archived project. Repository and other project resources are read-only.

`daemonize` API breakage when upgrading from Twisted <= 13.1 to >= 13.2

Due to a bug in the M-Lab installation procedure (see ooni-support pull request #43), we have run oonib against Twisted 14.0 on the M-Lab test slice.

In doing so, we uncovered a bug due to a changing API postcondition for the daemonize function/method in twisted.scripts._twistd_unix.

The details are thoroughly documented here:

https://github.com/m-lab-tools/ooni-support/issues/28#issuecomment-49205636

Note: twisted is very careful to provide well tested backwards compatibility for the public APIs, but this is a case of relying on a "private" API. An ideal solution would redesign Ooni to use only public twisted APIs. (I'm not sure of the rationale for the current design; can we document it / link to it here?)

A short term fix is to specify a constraint of twisted <= 13.1. A middle ground fix is to specify twisted >= 13.2 and cut'n'paste the relevant portions from the twisted code.

Trac:
Username: nathan-at-least

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

Child items 0

No child items are currently assigned. Use child items to break down this issue into smaller parts.

Activity

Trac added component::archived/ooni owner::hellais priority::medium reporter::nathan-at-least resolution::fixed status::closed type::defect labels 10 years ago

added component::archived/ooni owner::hellais priority::medium reporter::nathan-at-least resolution::fixed status::closed type::defect labels
Arturo Filastò @art · 10 years ago

A fix for this has been deployed to the latest master.

It has been achieved by refactoring oonib so that we don't use private twisted API's anymore.

Trac:
Status: new to closed
Resolution: N/A to fixed
Trac closed 10 years ago

closed

Please register or sign in to reply