Opened 5 years ago

Closed 5 years ago

#12647 closed defect (fixed)

updater needs to support use of symlinks

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-firefox-patch
Cc: brade, mikeperry, dcf Actual Points:
Parent ID: #4234 Points:
Reviewer: Sponsor:

Description

In #11429, the "second Tor Browser dock icon on Mac OS" problem was solved by using a different Info.plist for the browser app bundle that is used by meek. Symlinks are used to create the second app bundle (to avoid duplicating all of the browser binaries).

Unfortunately, based on code inspection, it looks like the Mozilla updater implementation does not support symlinks. I will confirm next week by doing some testing, but assuming I am correct we will need to either:

(1) Patch the updater code to handle symlinks.

or

(2) Avoid symlinks in the package (but I do not have a better idea for solving #11429).

I have not yet scoped the work for (1); hopefully it will not be too much work. If we always remove symlinks before applying an update, it may be enough to add support for a "addsymlink" verb in the update manifest.

Child Tickets

Change History (2)

comment:1 Changed 5 years ago by erinn

Component: Firefox Patch IssuesTor Browser
Keywords: tbb-firefox-patch added

comment:2 Changed 5 years ago by mcs

Resolution: fixed
Status: newclosed

The changes to support symlinks in the updater landed as part of the recent #4234 commit (see ticket:4234#comment:40).

Note: See TracTickets for help on using tickets.