Opened 5 years ago

Closed 5 years ago

#12648 closed task (fixed)

Upgrade go to 1.3

Reported by: dcf Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords: TorBrowserTeam201407
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Go 1.3 was released on 18 June. We're currently using 1.2. Here are the release notes: http://golang.org/doc/go1.3.

The main change we care about is it's supposed to have smaller binary sizes.

I tested that this patch runs and bootstraps meek on all three platforms.

Child Tickets

Attachments (1)

0001-Upgrade-go-to-1.3.patch (12.6 KB) - added by dcf 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by dcf

comment:1 Changed 5 years ago by dcf

Here's the change in overall bundle size. I built with attachment:0001-Upgrade-go-to-1.3.patch on top of 5b71d6072028e0d582ad7405597fd615586a0734.

go1.2 go1.3 diff
linux32 30480760 30350672 −130088
linux64 31974896 31883816 −91080
mac 34122441 33925485 −196956
windows 29524997 29432798 −92199

Here's the difference in the uncompressed size of the meek-client binary.

go1.2 go1.3 diff
linux32 6574768 5105304 −1469464
linux64 7918328 6332256 −1586072
mac 6502636 5053240 −1449396
windows 6075392 5192192 −883200

Somewhat bigger gains are going to come from omitting the symbol table.

comment:2 Changed 5 years ago by dcf

Status: newneeds_review

comment:3 Changed 5 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks. Merged.

Note: See TracTickets for help on using tickets.