Opened 5 years ago

Last modified 16 months ago

#12663 new defect

Orbot, libevent and BSD sed ( includes patch )

Reported by: cypherpunks Owned by: n8fr8
Priority: Low Milestone:
Component: Applications/Orbot Version: Android (Orbot): 1.0.0
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Compilation of Orbot stops at libevent if using BSD sed rather than GNU sed.

The error is :

sed -i 's@\(SUBDIRS = . include\) sample test@\1@' libevent/Makefile.am
sed: 1: "libevent/Makefile.am": extra characters at the end of l command

I have traced the problem to Orbot's external/Makefile.

There is a difference between BSD and GNU sed with regards to the inplace -i flag, both accept an argument for a file extension to backup to, if no extension is provided no backup is made, however BSD sed requires an argument even if it is empty, whereas GNU sed ignores it.

The attached patch adds an extension rather than provide an empty argument, this *should* work with both GNU and BSD sed, though I haven't tried it with the former.

Child Tickets

Attachments (1)

orbot-makefile.patch (660 bytes) - added by cypherpunks 5 years ago.
Orbot BSD sed patch

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by cypherpunks

Attachment: orbot-makefile.patch added

Orbot BSD sed patch

comment:1 Changed 16 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.