Newlines aren't preserved when bridges are copied to clipboard

When BridgeDB's web interface returns bridges, each bridge is displayed on its own line, as they should be. However, when the bridges are copied and pasted into a text field, the bridges are all smushed together in one line.

added bridgedb-0.2.4 bridgedb-https bridgedb-ui component::circumvention/bridgedb owner::isis priority::medium resolution::fixed status::closed type::defect labels

Trac:
preserve-newlines.patch

I've made a patch that I think corrects this issue.

Trac:
Status: new to needs_review

Sweet hack! I like it

Trac:
Username: chingucha

Replying to mttp:

I've made a patch that I think corrects this issue.

Hi mttp, thanks for the patch!

One thing, however:

Python code goes in .py files; Javascript in .js files; HTML in .html files. The HTML templates for the web interface are in lib/bridgedb/templates, and the spot that you want is here. However, you may need to change the associated div.bridgelines CSS class to fix it (here).

The reason this bug is occuring is that BridgeDB used to use <code>/<pre> tags to enclose the bridge lines. Then, when we started giving out bridge lines which included the fingerprint, using <code> made the line wrap around, causing the fingerprints to look like they were on new lines by themselves. I created the div.bridgelines class to fix this, but I'm no CSS wizard.

Trac:
Status: needs_review to needs_revision
Cc: sysrqb to sysrqb, isis
Keywords: N/A deleted, bridgedb-ui, bridgedb-https added

It seems that if this bug in Firefox (~13 years old now) were fixed, this wouldn't be an issue. You are right that since the div.bridge-lines block in custom.css includes the line white-space: pre-wrap; it's affected.

Okay, this is fixed in my fix/12664-bridgeline-newlines_r2 branch, and merged to develop for the upcoming 0.2.4 release. It also fixes other things, like making the "tor roots" logo actually be a background image, and it adds a "Select All" button which (if JS is enabled) will select all the bridge lines to try to reduce the amount of copy+paste errors that users are experiencing. The newlines, when pasted, actually translate to newlines.

Trac:
Resolution: N/A to fixed
Status: needs_revision to closed

Trac:
Keywords: N/A deleted, bridgedb-0.2.4 added

closed

mentioned in issue #13123 (moved)

mentioned in issue #14064 (moved)

moved to tpo/anti-censorship/bridgedb#12664 (closed)