Neuter meek-http-helper's default proxy setting
|Reported by:||dcf||Owned by:||dcf|
The headless meek-http-helper browser undoes Tor Browser's proxy setting:
// 0 is "No proxy". user_pref("network.proxy.type", 0);
This setting used to be necessary in order for the HTTPS requests to be made on the network without themselves trying to go through the local tor proxy. However, since #12120, we set the proxy type individually for every request (including a "direct" non-proxy when TOR_PT_PROXY is unset), so it's no longer necessary to change the global setting.
A good reason to leave the proxy set is so if someone manages to start Firefox using the meek-http-helper profile as a normal non-headless browser, it should fail closed, and give "the proxy server is refusing connections" rather than acting as an unproxied browser.
Even better, we can set the proxy URL to 127.0.0.1:9, the discard port, so it will fail even closeder if tor happens to be running on the usual port set by Tor Browser.
Change History (7)
comment:1 Changed 3 years ago by dcf
- Keywords TorBrowserTeam201407 added
- Status changed from new to needs_review
Changed 3 years ago by dcf
comment:5 Changed 3 years ago by dcf
- Keywords TorBrowserTeam201408 added; TorBrowserTeam201407 removed