Opened 3 years ago

Closed 9 months ago

#12685 closed defect (fixed)

Wrap fingerprint line on smaller displays

Reported by: Zitlo Owned by: irl
Priority: Very Low Milestone:
Component: Metrics/Atlas Version:
Severity: Normal Keywords: visibility of uptime
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

https://atlas.torproject.org/

When I use my iPhone for searching an Tor relay, I can´t see my uptime because the fingerprint line ist to long!

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by phw

Status: newneeds_information

Are you referring to the "details" page of a relay? Also, please provide a screenshot of the problem.

comment:2 Changed 10 months ago by karsten

Severity: Normal
Summary: TorAtlas search bug on iPhoneWrap fingerprint line on smaller displays

Picking a more descriptive summary line.

FWIW, on the ExoneraTor page we're inserting Unicode Character 'ZERO WIDTH SPACE' (U+200B) after 20 of the 40 fingerprint hex characters. Example:

<td>847B1F850344D7876491&#8203;A54892F904934E4EB85D</td>

Maybe that's an option for Atlas, too?

comment:3 Changed 9 months ago by RaBe

Status: needs_informationneeds_review

comment:4 Changed 9 months ago by RaBe

Owner: changed from phw to irl
Status: needs_reviewassigned

comment:5 Changed 9 months ago by RaBe

Status: assignedneeds_review

comment:6 Changed 9 months ago by irl

Owner: changed from irl to RaBe
Status: needs_reviewassigned

This change shouldn't be happening in the model, but in the view. It's not changing a property of the data but a property of the presentation. By changing it in the model it breaks generated URLs. You'll see that in the "Top 10" page, none of those links are usable as the URLs are generated from the fingerprint in the model and you end up with links like:

index.html#details/81B75D534F91BFB7C57A%E2%80%8BB67DA10BCEF622582AE8%E2%80%8B

Just for fun, by the time it gets to being a link it's also been URL encoded.

Looks like the right fix, but not in the right place.

comment:7 Changed 9 months ago by RaBe

Owner: changed from RaBe to irl

comment:8 Changed 9 months ago by RaBe

Status: assignedneeds_review

comment:9 Changed 9 months ago by irl

Resolution: fixed
Status: needs_reviewclosed

Perfect, merged, thanks. (:

Note: See TracTickets for help on using tickets.