Opened 5 years ago

Closed 3 years ago

#12692 closed defect (fixed)

Hide field names of empty fields

Reported by: arma Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

https://atlas.torproject.org/#details/3CA834833A7D8C7A3473BA21A4588EBCE1281AFC
lists "reject 1-65535" under the ipv4 exit policy summary (fine), but then

accept 213.0.0.0/8:8333
accept 213.0.0.0/8:443
accept 213.0.0.0/8:6667
reject *:*

under the ipv6 exit policy summary.

Oh wait, that's under the "exit policy", and there's a stray line "ipv6 exit policy summary" with nothing under it?

Maybe it shouldn't list an ipv6 exit policy summary if it isn't planning to list an ipv6 exit policy summary? :)

Child Tickets

Attachments (1)

treska.jpg (78.9 KB) - added by karsten 4 years ago.

Download all attachments as: .zip

Change History (12)

Changed 4 years ago by karsten

Attachment: treska.jpg added

comment:1 Changed 4 years ago by karsten

Severity: Normal
Summary: atlas mistakenly lists exit policy lines under "ipv6 exit policy"Hide field names of empty fields

I looked into this and found that it's just a presentation problem. The question is, should field names be displayed if field values are empty? And if the answer is yes, should there be as much as empty space as a possible field value would have required? I don't know the answer and will leave that to phw.

The relay above is not around anymore, so I'm adding a new relay as example:

https://atlas.torproject.org/#details/EB1668E7867F172C1B82EDBB8A2F49369523C790

Also, here's a screenshot of the Atlas page. Consider "Dir Address", "IPv6 Exit Policy Summary", and "Descriptor Published" as field names without field values:


This issue is not limited to exit policies, so I'm updating the ticket summary accordingly.

comment:2 Changed 3 years ago by RaBe

Owner: changed from phw to RaBe
Status: newassigned

comment:3 Changed 3 years ago by cypherpunks

The issue of the empty IPv6 exit policy summary was fixed in #14328 (see https://atlas.torproject.org/#details/5CECC5C30ACC4B3DE462792323967087CC53D947 for example). This ticket would be a good place to look for the same issue in other fields.

comment:4 Changed 3 years ago by RaBe

Owner: changed from RaBe to irl

I added alternate values for the fields "Contact", "Dir Address", (both) "Family Members" and "Descriptor Published" when otherwise they would be empty. This patch expects #20382 being already merged.

https://github.com/RaphaelBergmann/atlas/commit/140b66694b5e47478a91e8c625f2298571e442d6

comment:5 Changed 3 years ago by RaBe

Status: assignedneeds_review

comment:6 Changed 3 years ago by irl

Status: needs_reviewneeds_revision

RaBe: and for the bridge template? (:

There's something about the capitalisation and the full stop that makes me not like it. This could be a personal thing. I think the full stop is the most objectional part and I'd be happier without that, but I'll let you choose whether or not to capitalise the Nones.

comment:7 Changed 3 years ago by RaBe

Status: needs_revisionneeds_review

I copied the full stop and the capitalisation from an existing "None defined.", but I changed that one as well as my additions and now even included the bridge template :)

https://github.com/RaphaelBergmann/atlas/commit/247f40dbc55c697e4731574c4907dc59965c38aa

comment:8 Changed 3 years ago by irl

Resolution: fixed
Status: needs_reviewclosed

Had to rebase, but merged. Thanks. (:

comment:9 Changed 3 years ago by cypherpunks

I find "Published: Never" confusing.

Others as well:
https://lists.torproject.org/pipermail/tor-relays/2017-March/012048.html

What onionoo field is used for that?

comment:10 Changed 3 years ago by cypherpunks

Resolution: fixed
Status: closedreopened

comment:11 in reply to:  9 Changed 3 years ago by cypherpunks

Resolution: fixed
Status: reopenedclosed

Replying to cypherpunks:

I find "Published: Never" confusing.

Others as well:
https://lists.torproject.org/pipermail/tor-relays/2017-March/012048.html

What onionoo field is used for that?

This is issue is outside the scope of this ticket. I've opened #21630 to address it.

Note: See TracTickets for help on using tickets.