Opened 5 years ago

Closed 5 years ago

#12730 closed defect (fixed)

systemd unit file could use --verify-config in ExecStartPre

Reported by: intrigeri Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay, systemd
Cc: intrigeri Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The ExecStartPre directive (systemd.service(5)) allows to run commands before actually starting the service, and to _not_ start the service if one of these commands fail. It allows one to replicate the behavior that the tor initscript in Debian has, which is desirable IMO: if we don't have this, then when we install the systemd unit file in Debian, we have a regression.

Child Tickets

Change History (6)

comment:1 Changed 5 years ago by intrigeri

Status: newneeds_review

Implemented in the bug12730-systemd-verify-config branch on https://git-tails.immerda.ch/tor. Could this be a candidate for 0.2.5?

(More to come in this area, by the way.)

comment:2 Changed 5 years ago by intrigeri

Cc: intrigeri added

comment:3 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-final

comment:4 Changed 5 years ago by nickm

Looks fine. Could it get a changes file?

comment:5 Changed 5 years ago by intrigeri

Done, force-pushed my branch.

comment:6 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged into maint-0.2.5. Thanks!

Note: See TracTickets for help on using tickets.