Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#12761 closed task (fixed)

Switch to OS X 10.7 SDK in our Tor Browser Mac builds

Reported by: gk Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-gitian, ff38-esr, TorBrowserTeam201506R, tbb-5.0a3-essential
Cc: Actual Points:
Parent ID: #15772 Points:
Reviewer: Sponsor:

Description

Since https://bugzilla.mozilla.org/show_bug.cgi?id=941296 landed we can't build with the OS X 10.6 SDK anymore we currently use.

Child Tickets

Attachments (1)

0001-Bug-12761-Switch-to-ESR-38-for-OS-X.patch (2.0 KB) - added by gk 4 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by mikeperry

We can extract the OSX 10.7 SDK from an XCode 4 DMG, but apple only provides Xcode 5 now. We will have to track down an old XCode 4.5 somehow. Here's the extraction scripts:
http://devernay.free.fr/hacks/xcodelegacy/

comment:2 Changed 5 years ago by mikeperry

I found three sources of the 10.7 SDK online:
https://github.com/JuliaEichler/Mac_OSX_SDKs/tree/master/MacOSX10.7.sdk
and
https://github.com/phracker/MacOSX-SDKs
and
https://github.com/project-bitmark/pfennig/releases/download/v0.9.2.1-pre/MacOSX10.7.sdk.tar.gz

While I like phracker's style (aka "the baddest motherfucker"), the tarball version appears to be the newest version (for OSX 10.7.4 instead of 10.7.2 or earlier), and preserves mac property dotfiles.

comment:4 Changed 4 years ago by gk

Parent ID: #15772

comment:5 Changed 4 years ago by mikeperry

It appears that the pfennig mirror is now missing. Luckily I saved a backup copy at https://people.torproject.org/~mikeperry/mirrors/sources/MacOSX10.7.sdk.tar.gz.

da77bb0003fcca5ea8c4e8cb2da8828ded750c54afdcac29ec6f3b46ad5e3adf MacOSX10.7.sdk.tar.gz

That is the 10.7.4 SDK.

comment:6 Changed 4 years ago by gk

Owner: changed from tbb-team to gk
Status: newassigned

https://hg.mozilla.org/mozilla-central/rev/f4f90287d00a is breaking our build as $(TOOLCHAIN_PREFIX)nm is not pointing to our toolchain.

comment:7 Changed 4 years ago by gk

Keywords: TorBrowserTeam201506R added
Status: assignedneeds_review

Attached are the tor-browser changes we need. The changes in tor-browser-bundle will be in #16181.

comment:8 Changed 4 years ago by mikeperry

Keywords: tbb-5.0a3-essential added

Tag the set of things we should aim to understand/fix for the fist FF38-based TBB (5.0a3, on June 30th).

comment:10 Changed 4 years ago by arthuredelstein

Resolution: fixed
Status: needs_reviewclosed

comment:11 Changed 4 years ago by boklm

Maybe too late now, but shouldn't the title of the commit be "Switch to OS X 10.7 SDK for ESR 38" rather than "Switch to ESR38 for OS X" ?

comment:12 in reply to:  11 Changed 4 years ago by gk

Replying to boklm:

Maybe too late now, but shouldn't the title of the commit be "Switch to OS X 10.7 SDK for ESR 38" rather than "Switch to ESR38 for OS X" ?

Yes, that would have been better. But in the end it does not matter that much as we want to squash all the changes to Tor Browser's .mozconfig files into one commit which could then have the commit message "Adding Tor Browser's .mozconfig files" or something.

Note: See TracTickets for help on using tickets.