Opened 6 years ago

Closed 5 years ago

#12832 closed defect (fixed)

Typo in torrc.sample.in

Reported by: magnunor Owned by: nickm
Priority: Very Low Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords: typo, nickm-patch
Cc: Actual Points:
Parent ID: #11144 Points:
Reviewer: Sponsor:

Description

I found a typo in torrc.sample.in in https://gitweb.torproject.org/tor.git, and wrote a patch to correct it.

Child Tickets

Attachments (1)

0001-Fix-typo-in-torrc.sample.in.patch (925 bytes) - added by magnunor 6 years ago.
Patch for correcting typo in torrc.sample.in

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by magnunor

Patch for correcting typo in torrc.sample.in

comment:1 Changed 6 years ago by magnunor

Status: newneeds_review

comment:2 Changed 6 years ago by arma

Milestone: Tor: 0.2.5.x-final

Looks good!

We'll want to change the

Last updated 9 October 2013 for Tor 0.2.5.2-alpha.

line at the top too.

comment:3 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final

Thanks! These are nontrivial to fix, since making small changes to torrc.sample.in makes debian packages contain a new default torrc, which in turn can make Debian users need to rewrite their whole torrc files because we fixed a typo.

I'm hoping for a better solution for this whole arrangement: see #11144.

comment:4 Changed 5 years ago by nickm

Parent ID: #11144

comment:5 Changed 5 years ago by nickm

Keywords: nickm-patch added

Apply a nickm-patch keyword to tickets in needs_review in 0.2.6 where I wrote the patch, so I know which ones I can('t) review myself.

comment:6 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged parent.

Note: See TracTickets for help on using tickets.