Opened 5 years ago

Closed 5 years ago

#12884 closed enhancement (implemented)

Remove OBSOLETE options that have been OBSOLETE for a long time

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We've been using OBSOLETE() in config.c to mark options that used to be supported but which are no longer recognized. Maybe we should retire options that have been dead for over a certain number of years?

Child Tickets

Attachments (1)

0002-remove-all-obsolete-config-options-older-than-1-year.patch (8.0 KB) - added by snafu 5 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 5 years ago by snafu

Status: newneeds_review

I removed all options, declared in config.c, that were marked as obsolete more than one year ago.

AFAIK unit tests are ok.

comment:2 Changed 5 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.6.x-final
Resolution: implemented
Status: needs_reviewclosed

I've been a little more conservative, and tweaked your patch to only remove the OBSOLETE markers for options that have been obsolete since 0.2.3.x or earlier, since versions older than 0.2.3.x are now completely unsupported. Also, I've checked it in. Thanks!

Note: See TracTickets for help on using tickets.