Opened 4 years ago

Last modified 9 hours ago

#12885 needs_review defect

Windows Jump Lists fail for Tor Browser

Reported by: mcs Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-usability, TorBrowserTeam201812R
Cc: brade, gk, user1128, tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This ticket is a spinoff of #6062 (which I am going to close).

Windows 7 and 8 include a jump lists feature which is used by Firefox to provide a menu of tasks that may be accessed from the Start Menu or Taskbar ("Open new tab", "Open new window", etc.) These task items fail in Tor Browser because we have disabled remoting. Similarly, clicking the main "Tor Browser" pinned item fails for the same reason if Tor Browser is already running.

For now, we should change things so we do not show the jump list items. We can do so by setting these two prefs to false:

browser.taskbar.lists.frequent.enabled
browser.taskbar.lists.tasks.enabled

(we also want browser.taskbar.lists.recent.enabled = false but that is already done by default).

Also – although one would think that setting browser.taskbar.lists.enabled = false would be sufficient to turn everything off, doing that may leave old jump list menu items around. So it is better to turn off the three more specific prefs. See:

http://mxr.mozilla.org/mozilla-esr24/source/browser/modules/WindowsJumpLists.jsm#219

Child Tickets

Change History (8)

comment:1 Changed 4 years ago by gk

Cc: gk added

comment:3 Changed 2 years ago by bugzilla

Keywords: tbb-usability added
Severity: Normal

#11105 is a duplicate.

comment:4 Changed 2 years ago by gk

Cc: user1128 added

comment:5 Changed 2 weeks ago by gk

Cc: tbb-team added
Owner: changed from mcs to pospeselr
Status: newassigned

#28542 is a duplicate.

comment:6 Changed 3 days ago by pospeselr

Keywords: TorBrowserTeam201812R added
Status: assignedneeds_review

tor-browser patch implementing the options described in the ticket. Verified that a windows build no longer includes the jumplist entries.

https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_12885

comment:7 Changed 13 hours ago by mcs

Your patch looks OK, but how does the browser.taskbar.lists.enabled pref relate to the ones you are setting to false? It looks like it might be a "master switch" that could be used to turn everything off, but I would need to look more closely at the code to be sure.

comment:8 in reply to:  7 Changed 9 hours ago by pospeselr

Replying to mcs:

Your patch looks OK, but how does the browser.taskbar.lists.enabled pref relate to the ones you are setting to false? It looks like it might be a "master switch" that could be used to turn everything off, but I would need to look more closely at the code to be sure.

Based on some experimentation, the browser.taskbar.lists.enabled pref does not appear to act as a master switch in this way. After reading the code it looks like it may clear the 'recents' list when toggled from true to false, but that's about it.

Note: See TracTickets for help on using tickets.