Opened 5 years ago

Closed 5 years ago

#12899 closed defect (implemented)

Remove dirauth related naming stuff

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: 026-triaged-1
Cc: Actual Points:
Parent ID: #12898 Points:
Reviewer: Sponsor:

Description

I'm starting on this now.

Child Tickets

Change History (10)

comment:1 Changed 5 years ago by nickm

Keywords: 026-triaged-1 added

comment:2 Changed 5 years ago by Sebastian

bug12899 in my repository has a preliminary branch, which should get rid of the entire Naming system inside the dirauth but not yet switch to a bad-relays file. I'm currently testing it on gabelmoo, we'll see how it goes.

comment:3 Changed 5 years ago by Sebastian

Status: newneeds_review

comment:4 Changed 5 years ago by Sebastian

the bad-relays file stuff is being tracked in #13059, so this can be reviewed, merged & closed independently.

comment:5 Changed 5 years ago by Sebastian

Status: needs_reviewneeds_revision

nvm what I put here, I restarted gabelmoo at the wrong time.

Last edited 5 years ago by Sebastian (previous) (diff)

comment:6 Changed 5 years ago by Sebastian

Status: needs_revisionneeds_review

comment:7 Changed 5 years ago by Sebastian

(The patch is happily running on gabelmoo so far. All votes produced normally)

comment:8 Changed 5 years ago by nickm

Does dirserv_add_own_fingerprint do anything now? Right now, add_fingerprint_to_dir() with a 0 status seems equivalent to having no entry at all for a router.

Should NamingAuthoritativeDir become OBSOLETE ?

comment:9 Changed 5 years ago by Sebastian

dirserv_add_own_fingerprint does the initialization of the fingerprint_list, and Tor segfaults if you don't call it. It gets removed a couple of commits down the line, tho.

Yes, NamingAuthoritativeDir should be obsolete. I forgot to remove it, apparently. Fixup-patch in branch bug12899.

comment:10 Changed 5 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Squashed and merged to master. Thanks!

Note: See TracTickets for help on using tickets.