Opened 10 years ago

Closed 3 years ago

#1291 closed defect (wontfix)

Relays that aren't Valid never get Running

Reported by: arma Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: 0.2.1.22
Severity: Normal Keywords: tor-dirauth
Cc: arma, Sebastian, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by nickm)

We use router_is_active() for too many checks when directory authorities are
deciding how to handle relays that don't have the Valid flag.

Once upon a time, you could be missing a Valid flag and still get the Running
flag. That would cause clients to avoid using you except in circuit positions
specified in their 'AllowInvalidRelays' config option.

At present if we take away your Valid flag, we also necessarily take away your
Running flag.

We should sort out what we want to do. I think there is still a role for having
"dangerous" relays -- meaning you don't use them at the beginning or the end of your
path.

Maybe this means we should do away with the 'Valid' flag, and add a !badguard along
with !badexit?

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (8)

comment:1 Changed 9 years ago by nickm

Description: modified (diff)
Milestone: Tor: 0.2.3.x-final

Hm. Since we already removed all non-Running routers from the consensus, it looks like this bug means we did away with (most of?) the non-Valid routers too. Looks like nobody cared and nothing broke. Can we just say that non-Valid routers never get listed?

comment:2 Changed 9 years ago by arma

Component: Tor RelayTor Directory Authority

We could say that, but then we might as well phase out the Valid flag, because it is redundant with the Running flag.

...Which I guess is a fine plan, for code simplifications and all.

comment:3 Changed 9 years ago by arma

Deprecating the 'valid' flag probably wants a proposal.

comment:4 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

THis is a minor annoyance, and well worth fixing, but there's no reason it has to happen in the next release.

comment:5 Changed 7 years ago by nickm

Keywords: tor-auth added

comment:6 Changed 7 years ago by nickm

Component: Tor Directory AuthorityTor

comment:7 Changed 3 years ago by dgoulet

Cc: arma,Sebastian,nickmarma, Sebastian, nickm
Keywords: tor-dirauth added; tor-auth removed

Turns out that tor-auth is for directory authority so make it clearer with tor-dirauth

comment:8 Changed 3 years ago by nickm

Resolution: Nonewontfix
Severity: Normal
Status: newclosed

We don't care; the Valid flag is now deprecated, per proposal 272.

Note: See TracTickets for help on using tickets.