Opened 5 years ago

Closed 2 years ago

#12926 closed task (fixed)

Make sure our linker gets used when compiling Tor Browser for Windows

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-rbm, TorBrowserTeam201709
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

#12753 zeroed out the timestamp in the PE header but surprisingly not everywhere (e.g. not in the tor.exe). This might be due to the fact that our own linker is not used in these cases. See the hint in gitian-firefoy.yml

 XXX: the path to ld is hardcoded in mingw..

which would explain why tor.exe and the mingw-w64 libs we build in gitian-utils.yml are affected.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by cypherpunks

Keywords: tbb-rbm added; tbb-gitian removed
Severity: Major
Type: defecttask

How so? You are using your patched linker, and tor.exe would be without the .reloc section otherwise.

comment:2 in reply to:  1 Changed 2 years ago by gk

Keywords: TorBrowserTeam201709 added
Resolution: fixed
Status: newclosed

Replying to cypherpunks:

How so? You are using your patched linker, and tor.exe would be without the .reloc section otherwise.

That's actually a good test for the theory the bug was about: I ran the expert bundle and observed a working ASLR. Thus, we can be quite sure our linker is indeed used when compiling tor and related libraries.

Note: See TracTickets for help on using tickets.