Opened 5 years ago

Closed 5 years ago

#12934 closed enhancement (implemented)

Vagrant file and the like

Reported by: iwakeh Owned by:
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Keywords: vagrantfile
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Thanks for preparing the VagrantHowto, that really helped me to get started quickly!

I added some patches, also for the INSTALL file.
Could the jdk version be set to 1.7, as it is available for wheezy stable?

Please review and cherry pick the changes you find appropriate.

Some questions:

  • I couldn't make sense from the ln -s /srv/o in vagrant/bootstrap.sh
  • I couldn't find deanonymind.py mentioned in INSTALL. Thus, I didn't process geoip at all.
  • For testing using vagrant the vanilla server.xml does not need to be changed. Maybe, clearly point out that the example is for people who want to run their own onionoo server?

Child Tickets

Attachments (3)

bootstrap.sh.patch (404 bytes) - added by iwakeh 5 years ago.
just one line.
INSTALL.patch (2.2 KB) - added by iwakeh 5 years ago.
suggestions.
HOWTO-VAGRANT.md.patch (3.2 KB) - added by iwakeh 5 years ago.
suggestions.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by iwakeh

Attachment: bootstrap.sh.patch added

just one line.

Changed 5 years ago by iwakeh

Attachment: INSTALL.patch added

suggestions.

comment:1 Changed 5 years ago by iwakeh

Status: newneeds_review

comment:2 Changed 5 years ago by iwakeh

Type: defectenhancement

Changed 5 years ago by iwakeh

Attachment: HOWTO-VAGRANT.md.patch added

suggestions.

comment:3 in reply to:  description ; Changed 5 years ago by karsten

Replying to iwakeh:

Thanks for preparing the VagrantHowto, that really helped me to get started quickly!

Glad to hear!

I added some patches, also for the INSTALL file.
Could the jdk version be set to 1.7, as it is available for wheezy stable?

Once 1.7 is available on the production system, yes.

Please review and cherry pick the changes you find appropriate.

Committed to this branch together with another commit that is supposed to be squashed into the first. Does this look okay to you? If so, I'll squash and commit to master. Or feel free to squash, git commit --amend --reset-author, and git format-patch HEAD^ to be listed as patch author.

Some questions:

  • I couldn't make sense from the ln -s /srv/o in vagrant/bootstrap.sh

Indeed, that line should go away.

  • I couldn't find deanonymind.py mentioned in INSTALL. Thus, I didn't process geoip at all.

The deanonymind.py part in the INSTALL file is outdated. It's sufficient to download MaxMind's GeoIP2 database files now. I should update that file. Guess I'll do that in a more general effort to rework Onionoo's documentation (#13004).

  • For testing using vagrant the vanilla server.xml does not need to be changed. Maybe, clearly point out that the example is for people who want to run their own onionoo server?

I'm not sure what you mean. Want to provide a clarifying patch?

Thanks!

comment:4 in reply to:  3 Changed 5 years ago by iwakeh

  • For testing using vagrant the vanilla server.xml does not need to be changed. Maybe, clearly point out that the example is for people who want to run their own onionoo server?

I'm not sure what you mean. Want to provide a clarifying patch?


Yeah, that was a little unclear, second try :-)

  • for local testing the default server.xml does not need to be changed
  • for installing a new onionoo server the server.xml should be changed, find suggestions in the attached INSTALL file patch.

comment:5 Changed 5 years ago by iwakeh

Committed to this branch together with another commit that is supposed to be squashed into the first. Does this look okay to you?

Looks fine, except:

  • the maxmemory.value property is not in the build.xml of this branch, yet.
  • and the server.xml suggestion in INSTALL still contains the hard coded ip address 84.214.195.203

comment:6 Changed 5 years ago by karsten

Resolution: implemented
Status: needs_reviewclosed

Okay, here's what I did:

  • Added maxmemory.value to build.xml.
  • Didn't change the server.xml suggestion in INSTALL, because I didn't find any mention of the hard-coded IP address.
  • Added a note to the bottom of HOWTO-VAGRANT.md: "Note that Tomcat's default server.xml needs no changing for running in the development environment. See the INSTALL file for necessary changes in the production environment."
  • Pushed new commit to the previously mentioned branch.
  • Squashed the three new commits and pushed to master.

I think that concludes this ticket, which is why I'm closing. Please re-open if anything else remains. Thanks!

Note: See TracTickets for help on using tickets.