Opened 6 years ago

Last modified 5 months ago

#12957 new enhancement

Translation instruction about accesskey should be improved.

Reported by: Jason Owned by:
Priority: High Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Normal Keywords: bridgedb-ui, localization, ex-sponsor-19
Cc: emmapeel, sysrqb, cohosh Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor: Sponsor30-must


Here is an example:

Key: %sJ%sust give me bridges!
Occurrences: lib/bridgedb/templates/options.html:38
Resource: BridgeDB - bridgedb.pot
Developer note: TRANSLATORS: Please make sure the '%s' surrounding single letters at the beginning of words are present in your final translation. Thanks! (These are used to insert HTML5 underlining tags, to mark accesskeys for disabled users.)

Two issues about the note:

  1. For double-byte languages, e.g. Chinese/Japanese, there is no letter at the beginning of word.
  1. For other languages, there might be two translated strings have the same "%sJ%s" in the same page.

My suggestion:

For issue 1, add "%sJ%s" at the end of sentence.

For issue 2,  let's say, all acesskeys should not be changed when the strings are localized. If the first letters in English string and the translated string are different, then add "%sJ%s" at the end of sentence. When they happen to be the same letter, the instruction in developer note should be followed.

Child Tickets

Change History (10)

comment:1 Changed 6 years ago by isis

Status: newaccepted

Thanks for pointing out this issue! Admittedly, I recognised this while programming it, though I did not know how most translated pages deal with the case of accesskeys. In all the cases I researched, they merely did nothing, as I did.

I'd be more than happy to take a patch, if you'd like to contribute. In any cases where you think the accesskeys could be made more generic (there were some cases where, not knowing what to do, I tried to choose accesskeys which made the most sense to me, fully realising that they might not make sense to most users), I wouldn't mind seeing them changed. I figured that some accessibility for some differently-abled users was better than none. :/

comment:2 Changed 6 years ago by isis

Keywords: bridgedb-ui added

comment:3 Changed 6 years ago by isis

Cc: isis sysrqb added
Keywords: localization added
Status: acceptednew

Oops, I don't know why this was in an "accepted" state. I'm not working on it, anyone should feel free to take it and work on it!

comment:4 Changed 3 years ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:5 Changed 22 months ago by gaba

Owner: isis deleted
Points: 1
Priority: MediumHigh
Sponsor: Sponsor19
Status: newassigned

comment:6 Changed 17 months ago by gaba

Keywords: ex-sponsor-19 added

Adding the keyword to mark everything that didn't fit into the time for sponsor 19.

comment:7 Changed 17 months ago by phw

Sponsor: Sponsor19Sponsor30-must

Moving from Sponsor 19 to Sponsor 30.

comment:8 Changed 17 months ago by emmapeel

Cc: emmapeel added; isis removed

please let me know how can i help. the translators make mistakes often when translating these strings, and I think if we use a more standardized string replacement we will get better translations at the end!

maybe you find the second commandment here interesting to fix this problem:

(i love that text!)

comment:9 Changed 8 months ago by teor

Status: assignednew

Change tickets that are assigned to nobody to "new".

comment:10 Changed 5 months ago by cohosh

Cc: cohosh added

cohosh cc'ing myself on sponsor 30 work

Note: See TracTickets for help on using tickets.