Opened 4 years ago
Last modified 3 years ago
#12977 new defect
Fix Firefox's Full Screen Permissions Prompt
| Reported by: | mikeperry | Owned by: | tbb-team |
|---|---|---|---|
| Priority: | High | Milestone: | |
| Component: | Applications/Tor Browser | Version: | |
| Severity: | Normal | Keywords: | tbb-fingerprinting-resolution |
| Cc: | gk | Actual Points: | |
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
It looks like it may be slightly tricky but not impossible to fix the full screen permissions prompt. The full screen code lives in nsDocument::RequestFullScreen(). It actually registers an observer ("fullscreen-approved") topic for reacting to the prompt, but then goes ahead and reparents the element and full screens anyway.
We might be able to refactor this code such that it gets called from the observer callback, after the user has interacted with the dialog.
Probably best done after FF31-ESR though.
Child Tickets
Change History (4)
comment:1 Changed 4 years ago by
comment:2 Changed 4 years ago by
| Cc: | gk added |
|---|
comment:3 Changed 3 years ago by
| Keywords: | tbb-fingerprinting-resolution added; tbb-fingerprinting removed |
|---|
comment:4 Changed 3 years ago by
| Severity: | → Normal |
|---|
It is not needed to "fix the full screen permissions prompt", 'cause as you wrote "The full screen code lives in nsDocument::RequestFullScreen()" - is the code for request window only. Full screen should be disabled entirely (until resolution spoofing will be developed). Maybe Mozilla has a beta key in FF' config to do it, or we need to add an immediate return in code responsible for full screen switching.
Incidentally, if the user denies the prompt, I think the behavior should be the same as you get when 'full-screen-api.enabled' is false. In other words, the video should still become the size of the content window, just not full screen.