Opened 5 years ago

Last modified 3 years ago

#13012 assigned defect

Reviewing Bug #3229: Make content pref service memory-only + clearable

Reported by: arthuredelstein Owned by: boklm
Priority: Medium Milestone:
Component: Applications/Quality Assurance and Testing Version:
Severity: Normal Keywords: tbb-disk-leak
Cc: mikeperry, gk, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I noticed that nsContentPrefService.js can be expected to store prefs in memory, providing that any provided "loading context" has "usePrivateBrowsing" set to true, an assumption that may or may not hold for Firefox's Private Browsing (PB) mode. The patch for #3229 in addition applies to non-PB mode. Since Tor Browser uses PB mode by default, it's not entirely clear whether or not #3229 is needed.

To complicate matters, nsContentPrefService.js has been deprecated in favor of ContentPrefService2.jsm, at least in ESR31. In this new implementation, it looks like PB mode will also use an in-memory store, provided we make the same possibly dangerous assumption that loading contexts will always have "usePrivateBrowsing" set to true.

So my question is: should we drop the #3229 patch (assuming Firefox gets the loading contexts right), or should we be extra defensive and write a similar patch to apply to ContentPrefService2.jsm? Perhaps Mike has some insight here.

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by arthuredelstein

Status: newneeds_information

comment:2 Changed 5 years ago by gk

Cc: gk added

comment:3 Changed 3 years ago by gk

Cc: boklm added
Component: Applications/Tor BrowserApplications/Quality Assurance and Testing
Owner: changed from tbb-team to boklm
Severity: Normal
Status: needs_informationassigned

I think we should just write a test being part of our regular test suite.

Note: See TracTickets for help on using tickets.