Update gitian signing+sig check+upload scripts to use tag/branch

We should standardize the directory location of candidate builds, to make it clearer what a build directory corresponds to.

basename git describe --all is probably what we want to use as the target dir for a build.

added GeorgKoppen201501 component::applications/tor bundles/installation owner::erinn priority::medium resolution::fixed status::closed tbb-4.5-alpha-3 type::defect labels

Trac:
Keywords: TorBrowserTeam201409 deleted, TorBrowserTeam201410 added

Trac:
0001-Bug-13015-use-git-tags-to-set-tor-browser-version.patch

I attached a patch to do this. However, I did not run a build with those changes yet to check that everything is working. I will update this ticket when I've done it.

Here is a copy past from the commit message:

This commit adds a get-tb-version script which uses the git tags to
output the Tor Browser version and its build directory. The output
should be used with 'eval' in shell scripts to define the variables.
It takes as argument the type of version (release, alpha or beta).

If the current commit is tagged with tag tbb-4.2-build15, get-tb-version
will output this:

    TORBROWSER_VERSION=4.2
    TORBROWSER_BUILDDIR=4.2-build15
    TORBROWSER_SYMLINK_VERSION=1

If the current commit is not tagged, get-tb-version will use the version
from the last tagged commit in history. The build directory will include
the commit hash rather than a build number. The output will be something
like this:

    TORBROWSER_VERSION=4.0
    TORBROWSER_BUILDDIR=4.0-1a98e3efb368
    TORBROWSER_SYMLINK_VERSION=0

The TORBROWSER_BUILDDIR variable is used as the build directory.

The TORBROWSER_SYMLINK_VERSION variable indicate whether we should
create a symlink TORBROWSER_VERSION -> TORBROWSER_BUILDDIR.

The various files which source the versions files and use
TORBROWSER_VERSION have been updated to eval the output of
get-tb-version too, and use TORBROWSER_BUILDDIR as build directory.

Trac:
Cc: boklm to boklm, gk

Trac:
0001-Bug-13015-use-git-tags-to-set-tor-browser-version_v2.patch

new version of the patch

I uploaded a new version of the patch with the following changes:

• rebased on master
• adressing a comment from GeKo about running get-tb-version twice in mkbundle-*.sh

My test build with this patch failed for an unrelated reason (no space left on device in the container), and I have now restarted a new one.

Trac:
Keywords: TorBrowserTeam201410 deleted, TorBrowserTeam201411 added

Trac:
Keywords: TorBrowserTeam201411 deleted, TorBrowserTeam201412 added

Trac:
Keywords: TorBrowserTeam201412 deleted, TorBrowserTeam201501 added

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201501 deleted, TorBrowserTeam201501R added

Trac:
Keywords: N/A deleted, tbb-4.5-alpha-3 added

I added a branch ticket_13015_v3 on my user repo with the patch rebased on master: https://gitweb.torproject.org/user/boklm/tor-browser-bundle.git/commit/?h=ticket_13015_v3&id=54ccb6d5636539d565a3cd0b2fbe4127e7428804

Trac:
Keywords: TorBrowserTeam201501R deleted, GeorgKoppen201501R added

Looks good. This is merged in commit 0ca8d445690515e053e3dfbdaaf3b683b1021431.

Trac:
Status: needs_review to closed
Keywords: GeorgKoppen201501R deleted, GeorgKoppen201501 added
Resolution: N/A to fixed

closed

mentioned in issue #14212 (moved)

mentioned in issue #14303 (moved)

mentioned in issue tpo/applications/tor-browser#14212 (closed)

mentioned in issue tpo/applications/tor-browser#14303 (closed)