Opened 9 years ago

Closed 9 years ago

#1303 closed defect (fixed)

Implement URL filters for amo updates

Reported by: mikeperry Owned by:
Priority: Low Milestone:
Component: Applications/Torbutton Version: 1.2.4
Severity: Keywords:
Cc: mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

Torbutton should implement a ProtocolProxyFilter to optionally send its update requests over Tor. This
both helps to hide the Torbutton update from censors, and addresses concerns about a.m.o. being in a
position to log all Tor user IPs.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

torbutton-1.2.5pre3.xpi (422.2 KB) - added by mikeperry 9 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by mikeperry

Ok, this filter is implemented, but now I'm not sure that this is the right way to go. Sebastian
pointed out that he does not always have his Tor process running, and that there may be some confusion
when this option appears right next to the "Disable updates during Tor usage" button, even though they
can exist and operate independently.

He suggested splitting the 'Disable updates' option into a radiobutton with 3 options: "Update always",
"update only using Tor", "update only using non-tor".

I still kind of think that the filter for just Torbutton is a good one to have independent of how you
update the rest of your addons, but I'm not sure about how the UI should work, or if it should be on
by default.

comment:2 Changed 9 years ago by ioerror

I think that splitting the options is a great idea. I think by default that it should update only using Tor. If Tor isn't running, we shouldn't leak information (that an update may be needed but not installed, who or where we are, etc) to the network.

comment:3 Changed 9 years ago by mikeperry

Ok. That's a good point. If tor isn't running often, the user probably doesn't need updates that
badly, and can check for updates manually when it is. I think I'm just going to go ahead and make
the "Redirect Torbutton updates through Tor" and leave the other option as-is for now. That should
be a different feature request. I think if we do that, we really should make a separate "updates"
tab with just those options.

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre3.xpi added

comment:4 Changed 9 years ago by mikeperry

Ok, torbutton-1.2.5pre3.xpi in the attachments tab does this. I'll file a new feature request for changing
the updates option in a second. The reason why I didn't just do it is because A) I want to avoid changing
a bunch of translated strings right now. and 2). It will require additional logic that I'd have to test and verify.
and D). I'm trying to keep this release simple.

comment:5 Changed 9 years ago by mikeperry

Description: modified (diff)
Resolution: Nonefixed
Status: newclosed

Fixed in 1.2.5.

Note: See TracTickets for help on using tickets.