Opened 5 years ago

Last modified 17 months ago

#13033 new task

Apply mixed content blocking patch?

Reported by: mikeperry Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-security
Cc: arthuredelstein, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

There is a mostly-finished patch to improve the mixed content blocker to properly handle redirects. This patch would allow many more HTTPS-Everywhere rules to work properly with the Mixed Content Blocker enabled. We should see if we can help clean this patch up, if nothing else to make it work for us.

https://bugzilla.mozilla.org/show_bug.cgi?id=878890

Child Tickets

Attachments (1)

0001-Bug-13033-Backport-for-Redirects-should-go-through-M.patch (14.4 KB) - added by arthuredelstein 5 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by gk

Cc: gk added

comment:2 Changed 5 years ago by arthuredelstein

Keywords: tbb-esr31 added

comment:3 Changed 5 years ago by arthuredelstein

Keywords: ff31-esr added; tbb-esr31 removed

comment:4 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201410 added; TorBrowserTeam201410D removed

If we get an alpha out, we can consider trying to land these patches in it, but otherwise backporting these patches this month is not a hard deadline.

comment:5 Changed 5 years ago by mikeperry

Keywords: ff31-esr removed

comment:6 Changed 5 years ago by arthuredelstein

The Mozilla patch landed, so I backported it to tor-browser-31.2.0esr-4.x-1. The individual patches are here:
https://github.com/arthuredelstein/tor-browser/commits/13033
and I've attached a squashed version as a single patch file.

comment:7 Changed 5 years ago by arthuredelstein

Status: newneeds_review

comment:8 Changed 5 years ago by mikeperry

Keywords: tbb-4.5-alpha added

comment:9 Changed 5 years ago by mikeperry

Description: modified (diff)
Keywords: tbb-4.5-alpha removed
Status: needs_reviewnew

Crap. I messed this bug up by linking to the wrong Mozilla bug. I'm really sorry about that. The patch we want to backport is https://bugzilla.mozilla.org/show_bug.cgi?id=878890.

I've updated the description, too.

comment:10 Changed 5 years ago by mikeperry

Keywords: tbb-security added; TorBrowserTeam201410 removed

Also, since that patch doesn't look like it's progressed much since the first version, I'm taking this off our radar for now, and moving it to tbb-security.

comment:11 in reply to:  9 Changed 4 years ago by arthuredelstein

Replying to mikeperry:

Crap. I messed this bug up by linking to the wrong Mozilla bug. I'm really sorry about that. The patch we want to backport is https://bugzilla.mozilla.org/show_bug.cgi?id=878890.

No worries!

comment:12 Changed 17 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.