Opened 5 years ago

Closed 5 years ago

#13034 closed task (fixed)

Review individual rebased patches for Firefox 31

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201410, ff31-esr
Cc: mcs, brade, gk, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Arthur has rebased all of our patches already (see #12620), but the original authors should still review them to check for correctness, and to see if we might need to do anything additional for Firefox 31. In particular, the DOM Storage and Canvas APIs may have grown/changed to add new functionality that escapes our modifications.

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by mcs

brade and I will look at the DOM Storage and the Canvas patches.

comment:2 Changed 5 years ago by mcs

As mentioned in bug #12620, brade and I reviewed the Canvas and DOM Storage patches. We did improve the Canvas patch to preserve the TB 3.6.x "white image placeholder data" behavior.

We also looked for additional areas that we might need to patch. DOM Storage looks OK but see ticket:13021#comment:5 for some observations (and questions) about Canvas.

comment:3 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201410 added; TorBrowserTeam201409 removed

I would like us to take a second pass over these patches with respect to the originals after the branch has been rebased+squashed into its final form.

I think we may want one more squashing pass, so that for example all of the canvas, DOM storage, etc changes and unit tests are part of the same commit. I am pushing this out to October for this reason.

comment:4 Changed 5 years ago by mikeperry

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.