Opened 5 years ago

Closed 5 years ago

#13039 closed defect (fixed)

TBB needs to include the Go license.

Reported by: yawning Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201409 TorBrowserTeam201409Easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

(Per discussion with dcf in #12903, filing this as a separate ticket from the obfs4 stuff.)

With meek and (soon) obfs4 using Go and certain dependencies, the Go 3 clause BSD license should be distributed as part of the bundles under Browser/TorBrowser/Docs/Licenses/PluggableTransports.

The license: http://golang.org/LICENSE

Child Tickets

Attachments (1)

0001-Include-the-Go-license-as-required-for-certain-PTs.patch (3.1 KB) - added by yawning 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by yawning

I have this fixed in my obfs4 integration branch, so I will pull that part out and attach a patch shortly.

comment:2 Changed 5 years ago by yawning

Status: newneeds_review

comment:3 Changed 5 years ago by dcf

Keywords: TorBrowserTeam201409 TorBrowserTeam201409Easy added

It looks good to me. I'd say that the Go license is short enough we can just include it in the main LICENSE file, if you wanted to go that way. I think the reason that LICENSE.PYTHON and LICENSE.CC0 are split out into separate files is to prevent duplication because they are cross-referenced in multiple places.

comment:4 Changed 5 years ago by yawning

A lot of dependencies in the Go world use the boilerplate Go license, including go.net, go.crypto and agl's ed25519 package. I'm thinking that I should explicitly list those components and cross reference the Go license, so unless someone tells me otherwise, I will leave it split.

comment:5 Changed 5 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed in commit 2326062d5c514ee4ce45783b1ff05af6eadfdb52, thanks.

Note: See TracTickets for help on using tickets.