Opened 10 years ago

Closed 9 years ago

#1304 closed defect (fixed)

Implement URL filter for Google search queries

Reported by: mikeperry Owned by:
Priority: High Milestone:
Component: Applications/Torbutton Version: 1.2.4
Severity: Keywords:
Cc: mikeperry, MrSpock, Sebastian, ioerror Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

We need to rewrite Google URLs for two reasons:

  1. When they present a captcha, we should offer the user the option of auto-redirecting their query to

https://ixquick.com or https://ssl.scroogle.org

  1. The search plugins for Firefox send your platform, true user agent, and language. We need to

strip/alter this.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (5)

torbutton-1.2.5pre5.xpi (382.0 KB) - added by mikeperry 9 years ago.
torbutton-1.2.5pre6.xpi (382.6 KB) - added by mikeperry 9 years ago.
torbutton-1.2.5pre7.xpi (382.7 KB) - added by mikeperry 9 years ago.
torbutton-1.2.5pre8.xpi (383.0 KB) - added by mikeperry 9 years ago.
torbutton-1.2.5pre9.xpi (383.0 KB) - added by mikeperry 9 years ago.

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre5.xpi added

comment:1 Changed 9 years ago by mikeperry

This first one is done in the attachments tab. Google queries that result in a captcha are redirected to ixquick
after prompting the user. Configs have been added to select from ixquick, bing, or scroogle.

comment:2 Changed 9 years ago by mikeperry

Surprisingly modifying the outgoing request is not as easy as doing this 302 redirect. The URI in an nsIHttpChannel is
immutable: I can't change it, I can only create a new request.

I might be able to redirect the tab to a new url when such a request comes in, but such a hack would be much more
fragile than this one. I think it should probably wait for the next release.

comment:3 Changed 9 years ago by mikeperry

As an alternative we could use the nsIBrowserSearchService to potentially delete the google search engine
and replace it with a more benign version... That is also a little intrusive.

http://w-shadow.com/blog/2007/12/01/search-the-current-site-a-firefox-extension/
https://wiki.mozilla.org/Search_Service:API
http://www.oxymoronical.com/experiments/apidocs/interface/nsIBrowserSearchService

comment:4 Changed 9 years ago by mikeperry

Ok, I've coded this up. We should now be stripping off all that unique garbage at the end of Google urls
that Debian and other Lesser Distributions see fit to alter Firefox^WIceweasel to do so they can fuck it up
and accidentally introduce more bugdoors.

Try the torbutton-1.2.5pre6.xpi in the attachment tab and let me know if it works for your off-brand browsers.
You might need to apt-get install nepotism first though.

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre6.xpi added

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre7.xpi added

comment:5 Changed 9 years ago by Sebastian

So I tried it with "don't ask again" and "redirect", and it never loads ixquick. It sits in a loop, reloading ixquick every now and then, but never displays anything but the google page.

comment:6 Changed 9 years ago by mikeperry

I think this multiple redirect is due to javascrpt. Can you confirm if it does not happen when javascript is disabled?

comment:7 Changed 9 years ago by Sebastian

yes.

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre8.xpi added

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.5pre9.xpi added

comment:8 Changed 9 years ago by mikeperry

Description: modified (diff)
Resolution: Nonefixed
Status: newclosed

Fixed in 1.2.5.

Note: See TracTickets for help on using tickets.