Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13060 closed defect (implemented)

Remove the ability to mark relays as Bad directories

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: needs-spec tor-auth
Cc: Actual Points:
Parent ID: #12898 Points:
Reviewer: Sponsor:

Description

We've never used the feature according to arma, and while it doesn't add much complexity, it wouldn't hurt to get rid of it.

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by Sebastian

I just noticed that using this option never worked, because the special nickname !baddir wasn't handled. Even more reason to remove it.

comment:2 Changed 5 years ago by Sebastian

Status: newneeds_review

This depends on #12899, but is ready for review otherwise.

comment:3 Changed 5 years ago by Sebastian

(The patch is happily running on gabelmoo so far. All votes produced normally)

comment:4 Changed 5 years ago by nickm

Keywords: needs-spec tor-auth added

Hm. Before I contrive some reason why this might break something in the future... can anybody figure out why we implemented BadDir in the first place?

comment:5 Changed 5 years ago by Sebastian

Patch is in branch bug13060 in my torspec repo. I don't know why it was implemented

comment:6 Changed 5 years ago by nickm

Patch looks okay. I can merge it once there has been a spec patch, and once #12899 gets merged.

comment:7 Changed 5 years ago by Sebastian

did you see the comment above? proposed spec patch is in my torspec repo

comment:8 Changed 5 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

cherry-picked to master on top of rebased 12899.

Merged spec patch too.

comment:9 in reply to:  4 Changed 5 years ago by arma

Replying to nickm:

can anybody figure out why we implemented BadDir in the first place?

From svn r9242 it looks like we were trying to figure out how to handle directories that gave 503 busy responses "too often", and I guess it looked handy to have a way for directory authorities to tell clients to not even try that directory for now.

Note: See TracTickets for help on using tickets.