Opened 5 years ago

Closed 5 years ago

#13064 closed defect (fixed)

TestingDirAuthVoteGuard doesn't work with nicknames/fprs

Reported by: asn Owned by:
Priority: Low Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

TestingDirAuthVoteGuard is examined before rs->nickname is populated in set_routerstatus_from_routerinfo(), so nickname routersets won't work.

In my case, all relays in my testing network were marked as guards, but I'm not sure why.

Moving the TestingDirAuthVoteGuard examination further down the function might fix the problem, but we should also maek sure that it supports all other routerset types.

This is just a testing network issue btw.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by asn

Status: newneeds_review

Maybe bug13064 in my repo will do the trick. It seems to work in my testing.

comment:2 Changed 5 years ago by Sebastian

This would be made obsolete by #12900 and #12901, btw

comment:3 in reply to:  2 Changed 5 years ago by asn

Summary: TestingDirAuthVoteGuard doesn't work with nicknamesTestingDirAuthVoteGuard doesn't work with nicknames/fprs

Replying to Sebastian:

This would be made obsolete by #12900 and #12901, btw

This bug happens even if you specify fprs or orports. All those routerstatus elements are populated after TestingDirAuthVoteGuard gets examined

comment:4 Changed 5 years ago by Sebastian

ah. My bad :)

comment:5 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks okay to me. Merging.

Note: See TracTickets for help on using tickets.