smartlist_choose_node_by_bandwidth() does not consider bad exit
|Reported by:||asn||Owned by:||rl1987|
|Severity:||Keywords:||tor-client, 025-backport, 026-triaged-1, 2016-bug-retrospective|
smartlist_choose_node_by_bandwidth() does not check for the bad exit flag, and can return badexited relays. The sister function smartlist_choose_node_by_bandwidth_weights correctly checks for the bad exit flag.
The good thing is that node_sl_choose_by_bandwidth() will only use the faulty function if the bandwidth weight system fails. This should not happen to the current network though. Hence, this does not seem to be a big issue.
Change History (9)
comment:6 Changed 3 years ago by nickm
- Resolution set to fixed
- Status changed from needs_review to closed