Opened 5 years ago

Last modified 3 years ago

#13078 needs_revision enhancement

Add a ROUTERSET_ML config type, accept spaces in fingerprints?

Reported by: Sebastian Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay tor-dirauth configuration confparse
Cc: Actual Points:
Parent ID: #12898 Points: small
Reviewer: Sponsor:

Description

In my work for #13059, I stumbled over the fact that CONFIG_TYPE_ROUTERSET only accepts a single line. This makes editing a large file cumbersome if we use the \ syntax to end lines. Instead, I would propose adding a CONFIG_TYPE_ROUTERSET_ML option which unions the specified routersets.

Also, how about teaching routersets in general to ignore spaces in a fingerprint? arma notes that this might confuse people who think spaces should act as a separator, but this doesn't work currently and also goes against the manpage, so I wouldn't worry too much about it.

What do you think? I really want to do the former, the latter I don't care as much about, tho I believe it would be nice to have.

Child Tickets

Change History (25)

comment:1 Changed 5 years ago by Sebastian

Status: newneeds_review

branch bug13078 in my rep

comment:2 Changed 5 years ago by Sebastian

(It implements multiline routersets, not ignoring spaces in fingerprints)

comment:3 Changed 5 years ago by Sebastian

Milestone: Tor: 0.2.6.x-final
Type: defectenhancement

comment:4 Changed 5 years ago by nickm

Counterproposal: What if every routerset becomes multiline? Is there any reason not to make that change?

comment:5 Changed 5 years ago by Sebastian

I thought about it, but decided against it because it could change the semantics of a currently accepted Tor config. I'd be happy to rework the patch to make that change if you wanted, tho.

comment:6 Changed 5 years ago by arma

config.c:  V(EntryNodes,                  ROUTERSET,   NULL),
config.c:  V(ExcludeNodes,                ROUTERSET, NULL),
config.c:  V(ExcludeExitNodes,            ROUTERSET, NULL),
config.c:  V(ExitNodes,                   ROUTERSET, NULL),
config.c:  V(TestingDirAuthVoteGuard, ROUTERSET, NULL),

These are the only uses of ROUTERSET, right?

I think we could add another exception where you can write these lines more than once and we'll use the cumulative set of things you said. The old behavior was to only use the last one and warn that you're doing it wrong; the new behavior would be to stop warning and quietly use the earlier ones too. What could go wrong. :)

comment:7 Changed 5 years ago by Sebastian

I have a new implementation up in branch bug13078.

comment:8 Changed 5 years ago by nickm

I think this is okay, but it really needs tests. I'd also like us to make sure that + and / and HUP will all do the right thing.

comment:9 Changed 5 years ago by nickm

Status: needs_reviewneeds_revision

comment:10 Changed 5 years ago by Sebastian

Milestone: Tor: 0.2.6.x-finalTor: 0.2.7.x-final

comment:11 Changed 5 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:12 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

comment:13 Changed 4 years ago by nickm

Keywords: 028-triaged added

comment:14 Changed 4 years ago by nickm

Points: small
Priority: normalminor

comment:15 Changed 4 years ago by nickm

Keywords: pre028-patch added

comment:16 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

Move a bunch of (but not all) low-priority items to 0.2.???. If you write a patch, it can still get into 0.2.8

comment:17 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:18 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:19 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:20 Changed 3 years ago by nickm

Keywords: 027-triaged-in added

comment:21 Changed 3 years ago by nickm

Keywords: 027-triaged-in removed

comment:22 Changed 3 years ago by nickm

Keywords: 027-triaged-1-out removed

comment:23 Changed 3 years ago by nickm

Keywords: 028-triaged removed

comment:24 Changed 3 years ago by nickm

Keywords: pre028-patch removed

comment:25 Changed 3 years ago by nickm

Keywords: tor-relay tor-dirauth configuration confparse added
Severity: Normal
Note: See TracTickets for help on using tickets.