Opened 5 years ago

Closed 4 years ago

#13084 closed defect (fixed)

globe gets read/written backwards in its bandwidth graphs

Reported by: arma Owned by: isis
Priority: Medium Milestone:
Component: Metrics/Globe Version:
Severity: Keywords: globe-0.4.10, ui, usability
Cc: isis Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

https://atlas.torproject.org/#details/7552CA84FB125059DC2959A6BE01A6A8107B3523
shows a big jump in bandwidth, especially read bytes.

whereas
https://globe.torproject.org/#/relay/7552CA84FB125059DC2959A6BE01A6A8107B3523
shows a big jump in bandwidth, but especially written bytes.

Examination of the extrainfo descriptor for the relay in question shows that it's read-history, not write-history, that has the big numbers.

So I think globe has its labels mixed up?

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by isis

Owner: changed from rndm to isis
Status: newassigned

Changing Globe tickets to be owned by isis.

comment:2 Changed 4 years ago by ialexryan

This is an important and confusing wording issue. "Mean read bytes" should be changed to "Mean upload bandwidth usage" and "Mean written bytes" should be changed to "Mean download bandwidth usage".

This is both easy to implement and a really important usability win. Please do it ASAP so we can just cross this one off the list.

comment:3 in reply to:  description Changed 4 years ago by isis

Cc: isis added
Keywords: globe-0.4.10 ui usability added

Replying to arma:

https://atlas.torproject.org/#details/7552CA84FB125059DC2959A6BE01A6A8107B3523
shows a big jump in bandwidth, especially read bytes.

whereas
https://globe.torproject.org/#/relay/7552CA84FB125059DC2959A6BE01A6A8107B3523
shows a big jump in bandwidth, but especially written bytes.

Examination of the extrainfo descriptor for the relay in question shows that it's read-history, not write-history, that has the big numbers.

So I think globe has its labels mixed up?


Nice catch. The 'written bytes per second' and 'read bytes per second' labels when mousing over the bandwidth graphs are indeed mixed up:

GLOBE.RelayBandwidthView = GLOBE.HistoryGraphView.extend({
    graphOpts: {
        labelsKMG2: true
    },
    title: 'Bandwidth',
    graphs: ['readHistory', 'writeHistory'],
    labels: ['written bytes per second', 'read bytes per second'],
    legendPos: [{x:60,y:25}, {x:270,y:25}]
});

comment:4 Changed 4 years ago by isis

Resolution: fixed
Status: assignedclosed

Fixed in my trac-13084 branch (by simply switching the two strings, 'written bytes per second' and 'read bytes per second', around). Merged to master for Globe-0.4.10.

Note: See TracTickets for help on using tickets.