Use "Tor Browser" everywhere (space included)

This is a spinoff of bug #13087 (moved). We should change our .mozconfig files to have:

mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser"

and see if that causes any problems. If not, this is a simple change.

added MikePerry201409R MikePerry201410R TorBrowserTeam201409 TorBrowserTeam201410 component::applications/tor browser owner::mcs priority::medium resolution::fixed status::closed type::defect labels

Further research reveals that we will also need to change brandShortName inside these two files: browser/branding/official/locales/en-US/brand.dtd browser/branding/official/locales/en-US/brand.properties

Replying to mcs:

Further research reveals that we will also need to change brandShortName inside these two files: browser/branding/official/locales/en-US/brand.dtd browser/branding/official/locales/en-US/brand.properties

Also, Torbutton contains copies of these files in: src/chrome/locale//brand.dtd src/chrome/locale//brand.properties so we will need to change the Torbutton files too (that is where localization is handled; the Torbutton files are the ones that are really used).

The good news is that some translations already use a space within brandShortName, so adding one to en-US and other locales is unlikely to cause major bustage.

This is probably not top priority given the ESR31 work on our plate, but here are the three commits needed to use "Tor Browser" in (hopefully) all user-visible places within the browser:

https://gitweb.torproject.org/user/brade/tor-browser.git/commit/b269bb036db77aef26bef86d947006c27992b683

https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/41b90eae7d3d1a3664bc0d482862961a8ed3fcad

https://gitweb.torproject.org/user/brade/torbutton.git/commit/1eaed5a1f0d9fc01c9db8e1759c7dc3fc17337ad

Kathy and I did build a 4.0 nightly with these changes and did not notice any problem with the build process or the resulting packages.

Trac:
Keywords: N/A deleted, MikePerry201409R, TorBrowserTeam201409 added
Status: new to needs_review

Looks good to me although I have no clue whether we need to update transifex instead which gives us then back the "official" .dtd and .properties files. Anyway, I merged the tor-browser-bundle bits (commit e21bb4837a7affd469e413a2664f4a2bb5c2de4e).

Ok, I merged the browser and the Torbutton bits here for 4.0a3.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Space brakes strings produced for resource section in windows binaries. Instead "Tor Browser" it's just "Tor" now for Product Name and another fields. Windows using strings from resource section to report about problem with application, report "Tor has stopped working" is confusing for Tor Browser case.

Replying to cypherpunks:

Space brakes strings produced for resource section in windows binaries. Instead "Tor Browser" it's just "Tor" now for Product Name and another fields. Windows using strings from resource section to report about problem with application, report "Tor has stopped working" is confusing for Tor Browser case.

Thanks for looking into this, and I agree it causes confusion. I have a fix that I am testing now (added quotes when invoking version_win.pl inside config/version.mk).

Trac:
Resolution: fixed to N/A
Status: closed to reopened

Trac:
Cc: N/A to brade, mikeperry, gk
Owner: tbb-team to mcs
Status: reopened to assigned

OK, the simple fix works (add quotes around parameters passed to version_win.pl). Here it is:

https://gitweb.torproject.org/user/brade/tor-browser.git/commit/26735f870de9ec7cb7b9e6aa5bbf4fd9f92ea4fd

It would be nice to get this into TB soon since the Windows crash dialogs that read "Tor has stopped working" are confusing.

Trac:
Keywords: N/A deleted, MikePerry201410R, TorBrowserTeam201410 added
Status: assigned to needs_review

Merged for 4.0.1 and 4.5-alpha.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #16496 (moved)

moved to tpo/applications/tor-browser#13091 (closed)

mentioned in issue tpo/applications/tor-browser#16496 (closed)