Opened 5 years ago

Closed 5 years ago

#13091 closed defect (fixed)

Use "Tor Browser" everywhere (space included)

Reported by: mcs Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201409, MikePerry201409R, TorBrowserTeam201410, MikePerry201410R
Cc: brade, mikeperry, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is a spinoff of bug #13087. We should change our .mozconfig files to have:

mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser"

and see if that causes any problems. If not, this is a simple change.

Child Tickets

Change History (11)

comment:1 Changed 5 years ago by mcs

Further research reveals that we will also need to change brandShortName inside these two files:

browser/branding/official/locales/en-US/brand.dtd
browser/branding/official/locales/en-US/brand.properties

comment:2 in reply to:  1 Changed 5 years ago by mcs

Replying to mcs:

Further research reveals that we will also need to change brandShortName inside these two files:

browser/branding/official/locales/en-US/brand.dtd
browser/branding/official/locales/en-US/brand.properties

Also, Torbutton contains copies of these files in:

src/chrome/locale/*/brand.dtd
src/chrome/locale/*/brand.properties

so we will need to change the Torbutton files too (that is where localization is handled; the Torbutton files are the ones that are really used).

The good news is that some translations already use a space within brandShortName, so adding one to en-US and other locales is unlikely to cause major bustage.

comment:3 Changed 5 years ago by mcs

Keywords: TorBrowserTeam201409 MikePerry201409R added
Status: newneeds_review

This is probably not top priority given the ESR31 work on our plate, but here are the three commits needed to use "Tor Browser" in (hopefully) all user-visible places within the browser:

https://gitweb.torproject.org/user/brade/tor-browser.git/commit/b269bb036db77aef26bef86d947006c27992b683

https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/41b90eae7d3d1a3664bc0d482862961a8ed3fcad

https://gitweb.torproject.org/user/brade/torbutton.git/commit/1eaed5a1f0d9fc01c9db8e1759c7dc3fc17337ad

Kathy and I did build a 4.0 nightly with these changes and did not notice any problem with the build process or the resulting packages.

comment:4 Changed 5 years ago by gk

Looks good to me although I have no clue whether we need to update transifex instead which gives us then back the "official" .dtd and .properties files. Anyway, I merged the tor-browser-bundle bits (commit e21bb4837a7affd469e413a2664f4a2bb5c2de4e).

comment:5 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Ok, I merged the browser and the Torbutton bits here for 4.0a3.

comment:6 Changed 5 years ago by cypherpunks

Space brakes strings produced for resource section in windows binaries. Instead "Tor Browser" it's just "Tor" now for Product Name and another fields. Windows using strings from resource section to report about problem with application, report "Tor has stopped working" is confusing for Tor Browser case.

comment:7 in reply to:  6 Changed 5 years ago by mcs

Replying to cypherpunks:

Space brakes strings produced for resource section in windows binaries. Instead "Tor Browser" it's just "Tor" now for Product Name and another fields. Windows using strings from resource section to report about problem with application, report "Tor has stopped working" is confusing for Tor Browser case.

Thanks for looking into this, and I agree it causes confusion. I have a fix that I am testing now (added quotes when invoking version_win.pl inside config/version.mk).

comment:8 Changed 5 years ago by mcs

Resolution: fixed
Status: closedreopened

comment:9 Changed 5 years ago by mcs

Cc: brade mikeperry gk added
Owner: changed from tbb-team to mcs
Status: reopenedassigned

comment:10 Changed 5 years ago by mcs

Keywords: TorBrowserTeam201410 MikePerry201410R added
Status: assignedneeds_review

OK, the simple fix works (add quotes around parameters passed to version_win.pl). Here it is:

https://gitweb.torproject.org/user/brade/tor-browser.git/commit/26735f870de9ec7cb7b9e6aa5bbf4fd9f92ea4fd

It would be nice to get this into TB soon since the Windows crash dialogs that read "Tor has stopped working" are confusing.

comment:11 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Merged for 4.0.1 and 4.5-alpha.

Note: See TracTickets for help on using tickets.