Opened 6 years ago

Closed 6 years ago

#13102 closed defect (fixed)

error: 'SSIZE_MAX' undeclared in utils.c

Reported by: gk Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: regression
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It seems commit 9b850f9200c2d2eac4053cfaa74873bbbe4f0b95 breaks compilation with mingw-w64 (at least with the GCC 4.9.1 based we plan to use in Tor Browser based on ESR 31). The error message is:

src/common/util.c: In function 'esc_for_log':
src/common/util.c:1211:3: error: 'SSIZE_MAX' undeclared (first use in this function)
src/common/util.c:1211:3: note: each undeclared identifier is reported only once for each function it appears in

Child Tickets

Change History (2)

comment:1 Changed 6 years ago by nickm

Keywords: regression added
Milestone: Tor: 0.2.6.x-final

Ug. We should fix torint.h so that it declares SSIZE_MAX and SIZE_MAX, and fix everything in the code that looks at SIZE_T_MAX and SSIZE_T_MAX to look at SIZE_MAX and SSIZE_MAX instead.

comment:2 Changed 6 years ago by nickm

Resolution: fixed
Status: newclosed

Should be fixed now in master; thanks!

Note: See TracTickets for help on using tickets.